Closed
Bug 659356
Opened 14 years ago
Closed 14 years ago
Update addons.js module to use waitFor and a capital letter for the class
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
Details
Attachments
(1 file)
|
41.48 KB,
patch
|
gmealer
:
review+
|
Details | Diff | Splinter Review |
There are some instances in the addons.js module where we are having commented out waitFor calls in favor of waitForEval. Those have to be updated. Also the class name should start with a capital letter.
Patch upcoming.
|
Assignee | |
Comment 1•14 years ago
|
||
Simple and straight forward patch. Cleans up the module for the upcoming Discovery Pane work.
Attachment #534815 -
Flags: review?(gmealer)
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13767491
Comment on attachment 534815 [details] [diff] [review]
Patch v1
Looks fine. r+
Please go ahead and land, since I'm unsure if this also backports.
Attachment #534815 -
Flags: review?(gmealer) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/43bc325033b9 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/3dd5f29743a0 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/095dce92b5ea (beta)
The patch doesn't work on mozilla-2.0, but I don't think that we should go back that far.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•