hg preoutgoing hook should check email address format

RESOLVED FIXED in Q3 11 - Serrano

Status

--
enhancement
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: pnkfelix, Unassigned)

Tracking

unspecified
Q3 11 - Serrano
Bug Flags:
flashplayer-qrb +

Details

Attachments

(1 attachment)

I use qimportbz to mesh Mercurial Queues with Bugzilla.

Its great, except that (at least on my version), it imports patches without the domains on the email addresses.  Unfortunately this sometimes makes its way onto the changesets I push, e.g.:

  http://hg.mozilla.org/tamarin-redux/rev/5abd3af1898a  

I want to fix that.  I've looked into fixing qimportbz, but that's harder than you'd think to do properly (see Bug 534307).

Its easier (and more general) to just try to enforce the rule in the preoutgoing hook, the same way we heuristically enforce the log message format (for those who opt-in to using the hook).
Created attachment 534853 [details] [diff] [review]
checks for email address including a domain
Attachment #534853 - Flags: review?(cpeyer)

Comment 2

7 years ago
Comment on attachment 534853 [details] [diff] [review]
checks for email address including a domain

Looks good.
Attachment #534853 - Flags: review?(cpeyer) → review+

Comment 3

7 years ago
changeset: 6347:8b9de9a27a8f
user:      Felix S Klock II <fklockii@adobe.com>
summary:   Bug 659401: check author includes email with domain on push (r=cpeyer).

http://hg.mozilla.org/tamarin-redux/rev/8b9de9a27a8f

Updated

7 years ago
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Flags: flashplayer-qrb+
Resolution: --- → FIXED
Target Milestone: --- → Q3 11 - Serrano
You need to log in before you can comment on or make changes to this bug.