659401 - hg preoutgoing hook should check email address format

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tools, enhancement)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

I use qimportbz to mesh Mercurial Queues with Bugzilla.

Its great, except that (at least on my version), it imports patches without the domains on the email addresses.  Unfortunately this sometimes makes its way onto the changesets I push, e.g.:

  http://hg.mozilla.org/tamarin-redux/rev/5abd3af1898a  

I want to fix that.  I've looked into fixing qimportbz, but that's harder than you'd think to do properly (see Bug 534307).

Its easier (and more general) to just try to enforce the rule in the preoutgoing hook, the same way we heuristically enforce the log message format (for those who opt-in to using the hook).

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: checks for email address including a domain

Comment 2

[Chris Peyer]

Comment on attachment 534853 [details] [diff] [review]
checks for email address including a domain

Looks good.

Comment 3

[Tamarin Bot]

changeset: 6347:8b9de9a27a8f
user:      Felix S Klock II <[e-mail]>
summary:   Bug 659401: check author includes email with domain on push (r=cpeyer).

http://hg.mozilla.org/tamarin-redux/rev/8b9de9a27a8f