Closed Bug 659402 Opened 12 years ago Closed 12 years ago
Fullscreen video controls are broken
Touch events shifted us from using Browser:MouseUp messages for clicks to Browser:MouseClick. Unfortunately, video controls redispatch their own events, and forgot to come to the party. Patch updates them.
Attachment #534854 - Flags: review?(mbrubeck)
we'll need this on aurora, so ask for approval after you get an r+
Attachment #534854 - Flags: review?(mbrubeck) → review+
Comment on attachment 534854 [details] Patch Asking for aurora approval
Attachment #534854 - Flags: approval-mozilla-aurora?
Just to note for the aurora approval, this patch is very low risk (code only runs on Fennec, Fullscreen video mode) on and fixes a regression we introduced when we checked in touchevents. Without it, it is impossible to control of exit fullscreen video requiring the user to quit fennec (hard to do) to get back to normal use.
Comment on attachment 534854 [details] Patch let this bake on trunk for a day or two before landing on aurora
Attachment #534854 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Hmm... did I forget to put the first push in here? mc: http://hg.mozilla.org/mozilla-central/rev/24f331bd335f aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/12c44a8c34f5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Verified Fixed on: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110607 Firefox/7.0a1 Fennec/7.0a1 Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110607 Firefox/6.0a2 Fennec/6.0a2 Device: HTC Desire Z (Android 2.2)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.