Last Comment Bug 659536 - Replace nsContentUtils::GetIntPref() with Preferences::GetInt()
: Replace nsContentUtils::GetIntPref() with Preferences::GetInt()
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
:
Mentors:
Depends on: 656826
Blocks: 660121
  Show dependency treegraph
 
Reported: 2011-05-24 18:13 PDT by Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
Modified: 2011-05-26 17:07 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch for implementing GetUint() (2.17 KB, patch)
2011-05-24 18:13 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
roc: review+
Details | Diff | Splinter Review
Patch v1.0 (53.61 KB, patch)
2011-05-24 18:14 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28))
roc: review+
Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2011-05-24 18:13:13 PDT
Created attachment 534959 [details] [diff] [review]
Patch for implementing GetUint()
Comment 1 Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2011-05-24 18:14:10 PDT
Created attachment 534960 [details] [diff] [review]
Patch v1.0
Comment 2 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-05-24 20:16:14 PDT
Comment on attachment 534959 [details] [diff] [review]
Patch for implementing GetUint()

Review of attachment 534959 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 3 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-05-24 20:20:31 PDT
Comment on attachment 534960 [details] [diff] [review]
Patch v1.0

Review of attachment 534960 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 4 Masayuki Nakano [:masayuki] (Mozilla Japan) (Offline: 9/19, 9/22-9/25, 9/28)) 2011-05-24 23:39:51 PDT
http://hg.mozilla.org/mozilla-central/rev/1b9d9bb14005
http://hg.mozilla.org/mozilla-central/rev/836aa9658341

Note You need to log in before you can comment on or make changes to this bug.