659576 - bool nsGlobalWindow::ConfirmDialogAllowed() returns nsresult

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

bool nsGlobalWindow::ConfirmDialogAllowed() returns NS_ERROR_NOT_INITIALIZED.

See the FORWARD_TO_OUTER macro.

This regressed by:
http://hg.mozilla.org/mozilla-central/rev/02ad9fd3361c

Comment 1

[Josh Matthews [:jdm]]

jst, I'm sure you don't mind if someone else takes this off your hands.

Comment 2

[James Hobin [:hobinjk]]

Attachment: Patch to fix FORWARD_TO_OUTER potentially returning anything but false

This is the first patch I've submitted, so hopefully it's anywhere near correct.

Comment 3

[Josh Matthews [:jdm]]

Comment on attachment 559766 [details] [diff] [review]
Patch to fix FORWARD_TO_OUTER potentially returning anything but false

Thanks for the patch James! For future reference, if you could follow the instructions at https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F when creating patches, that will make it easier to check them in. I'm going to let an official peer of this code review it.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 559766 [details] [diff] [review]
Patch to fix FORWARD_TO_OUTER potentially returning anything but false

Thanks for the patch! r=jst

Comment 5

[Ed Morley [:emorley]]

In my queue, which needs to go to try server for some of the other items in it, but will land on mozilla-inbound afterwards. Thanks for the patch James :-)

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f0f350512b05

Comment 6

[Ed Morley [:emorley]]

Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f315828a0aa

Within the next day or so this will then be merged to mozilla-central :-)

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/4f315828a0aa

Thanks a lot James for your patch!  Hope to see you around more often.  :-)