The default bug view has changed. See this FAQ.

bool nsGlobalWindow::ConfirmDialogAllowed() returns nsresult

RESOLVED FIXED in mozilla9

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: masayuki, Assigned: hobinjk)

Tracking

({regression})

Trunk
mozilla9
regression
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug] [mentor=jdm])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
bool nsGlobalWindow::ConfirmDialogAllowed() returns NS_ERROR_NOT_INITIALIZED.

See the FORWARD_TO_OUTER macro.

This regressed by:
http://hg.mozilla.org/mozilla-central/rev/02ad9fd3361c

Comment 1

6 years ago
jst, I'm sure you don't mind if someone else takes this off your hands.
Assignee: jst → nobody
Whiteboard: [good first bug] [mentor=jdm]
(Assignee)

Comment 2

6 years ago
Created attachment 559766 [details] [diff] [review]
Patch to fix FORWARD_TO_OUTER potentially returning anything but false

This is the first patch I've submitted, so hopefully it's anywhere near correct.
Attachment #559766 - Flags: review?(josh)

Comment 3

6 years ago
Comment on attachment 559766 [details] [diff] [review]
Patch to fix FORWARD_TO_OUTER potentially returning anything but false

Thanks for the patch James! For future reference, if you could follow the instructions at https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F when creating patches, that will make it easier to check them in. I'm going to let an official peer of this code review it.
Attachment #559766 - Flags: review?(josh) → review?(jst)
Comment on attachment 559766 [details] [diff] [review]
Patch to fix FORWARD_TO_OUTER potentially returning anything but false

Thanks for the patch! r=jst
Attachment #559766 - Flags: review?(jst) → review+

Updated

6 years ago
Keywords: checkin-needed
In my queue, which needs to go to try server for some of the other items in it, but will land on mozilla-inbound afterwards. Thanks for the patch James :-)

https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f0f350512b05
Assignee: nobody → hobinjk
Status: NEW → ASSIGNED
Keywords: checkin-needed
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4f315828a0aa

Within the next day or so this will then be merged to mozilla-central :-)
Flags: in-testsuite-
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/4f315828a0aa

Thanks a lot James for your patch!  Hope to see you around more often.  :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.