Remove EXTRA_DSO_LDOPTS, EXTRA_DSO_LIBS and OS_LIBS, now that libxul always built

VERIFIED FIXED in mozilla7

Status

()

Core
Build Config
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-bs)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Remove all of:
http://mxr.mozilla.org/mozilla-central/search?string=gkgfx

Apart from:
http://mxr.mozilla.org/mozilla-central/source/gfx/src/Makefile.in#47
http://mxr.mozilla.org/mozilla-central/source/toolkit/library/libxul-config.mk#128
I think you can completely remove EXTRA_DSO_LDOPTS, EXTRA_DSO_LIBS and OS_LIBS from any Makefile.in where LIBXUL_LIBRARY = 1.
(Assignee)

Comment 2

6 years ago
Sounds like a plan, morphing.
Summary: Remove redundant gkgfx dependencies now that libxul is always built → Remove EXTRA_DSO_LDOPTS, EXTRA_DSO_LIBS and OS_LIBS, now that libxul always built
(Assignee)

Comment 3

6 years ago
Created attachment 535159 [details] [diff] [review]
Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

http://dev.philringnalda.com/tbpl/?tree=Try&rev=c2798493e31f

(The b-s repo does not yet contain the bug 648911 changes, so I decided to base this off of m-c for now, to make it easier to rebase on b-s later, once it merges with m-c).
Attachment #535159 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

6 years ago
Attachment #535159 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 4

6 years ago
Created attachment 535170 [details] [diff] [review]
Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

Typo fixed.

http://dev.philringnalda.com/tbpl/?tree=Try&rev=669aac8cadf5
Attachment #535159 - Attachment is obsolete: true
(Assignee)

Comment 5

6 years ago
Comment on attachment 535170 [details] [diff] [review]
Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

Passed try.

Thanks Ted :-)
Attachment #535170 - Flags: review?(ted.mielczarek)
Comment on attachment 535170 [details] [diff] [review]
Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

Review of attachment 535170 [details] [diff] [review]:
-----------------------------------------------------------------

I really only skimmed this patch, but it looks good and it's 99% removals. If it passed try it should be fine.
Attachment #535170 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 7

6 years ago
Created attachment 538744 [details] [diff] [review]
Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1

Updated to build-system tip, no other changes, carrying forwards r+. Thanks Ted :-)

Ideally needs to land on build-system rather than m-c. Has passed try (comment 4), has author + commit message filled out.
Attachment #535170 - Attachment is obsolete: true
Attachment #538744 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [to land on build-system please]
http://hg.mozilla.org/projects/build-system/rev/2f965cea44ff
Keywords: checkin-needed
Whiteboard: [to land on build-system please] → fixed-in-bs
http://hg.mozilla.org/mozilla-central/rev/2f965cea44ff
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla7
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Is there any way I can verify this on the QA side?

I checked and that all the files are removed from the repo.
http://hg.mozilla.org/mozilla-central/file/e0acef471ab2

Is that enough to mark this as VERIFIED FIXED?

Thanks!
This is just cleanup, it's not worth verifying. If you want to mark it VERIFIED, feel free, but it doesn't accomplish anything.
Based on Comment 11 marking this as VERIFIED FIXED.

Thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.