Last Comment Bug 659632 - Add MOZ_MEMORY_ELF and refactor memalign visibility on ELF
: Add MOZ_MEMORY_ELF and refactor memalign visibility on ELF
Product: Core
Classification: Components
Component: Memory Allocator (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla7
Assigned To: Paul Biggar
: Mike Hommey [:glandium]
Depends on:
Blocks: 414946
  Show dependency treegraph
Reported: 2011-05-25 07:11 PDT by Paul Biggar
Modified: 2011-05-26 16:30 PDT (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Add MOZ_MEMORY_ELF (2.50 KB, patch)
2011-05-25 07:11 PDT, Paul Biggar
respindola: review+
Details | Diff | Splinter Review
Final version to be checked-in (2.57 KB, patch)
2011-05-26 07:01 PDT, Paul Biggar
no flags Details | Diff | Splinter Review

Description Paul Biggar 2011-05-25 07:11:34 PDT
Created attachment 535051 [details] [diff] [review]

A minor refactoring of bug 635790. __GNUC__ does not imply ELF on Darwin systems.
Comment 1 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2011-05-25 08:22:29 PDT
Comment on attachment 535051 [details] [diff] [review]

Review of attachment 535051 [details] [diff] [review]:

I think this is OK. I had no idea this file was built on OS X at all.
Comment 2 Paul Biggar 2011-05-25 08:28:51 PDT
It's not, but it will be after bug 4141946.
Comment 3 Paul Biggar 2011-05-26 07:01:23 PDT
Created attachment 535325 [details] [diff] [review]
Final version to be checked-in
Comment 5 Paul Biggar 2011-05-26 16:30:56 PDT
Thanks Ehsan!

Note You need to log in before you can comment on or make changes to this bug.