Add MOZ_MEMORY_ELF and refactor memalign visibility on ELF

RESOLVED FIXED in mozilla7

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: paul.biggar, Assigned: paul.biggar)

Tracking

unspecified
mozilla7
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

8 years ago
Created attachment 535051 [details] [diff] [review]
Add MOZ_MEMORY_ELF

A minor refactoring of bug 635790. __GNUC__ does not imply ELF on Darwin systems.
Attachment #535051 - Flags: review?(respindola)
Comment on attachment 535051 [details] [diff] [review]
Add MOZ_MEMORY_ELF

Review of attachment 535051 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is OK. I had no idea this file was built on OS X at all.
Attachment #535051 - Flags: review?(respindola) → review+
(Assignee)

Comment 2

8 years ago
It's not, but it will be after bug 4141946.
(Assignee)

Comment 3

8 years ago
Created attachment 535325 [details] [diff] [review]
Final version to be checked-in
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
Assignee: nobody → pbiggar

Comment 4

8 years ago
http://hg.mozilla.org/mozilla-central/rev/4e68c87ee48d
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

8 years ago
Thanks Ehsan!
You need to log in before you can comment on or make changes to this bug.