659672 - Turning autofill to true triggers google searches for some results

Status: RESOLVED INACTIVE

(Firefox :: Address Bar, defect)

Description

[Ed Lee :Mardak]

When I type "#firefox" and press enter on Nightly, I end up on a google search for "#firefox >> https://twitter.com/#!/search/%23firefox"

http://www.google.com/search?q=%23firefox+%3E%3E+https%3A%2F%2Ftwitter.com%2F%23%21%2Fsearch%2F%2523firefox&ie=utf-8&oe=utf-8&aq=t&rls=org.mozilla:en-US:unofficial&client=firefox-a

The first result does indeed have a url of "https://twitter.com/#!/search/%23firefox"


It seems like the patch from bug 566489 removed the conditional execution of inserting " >> ":

>+++ b/toolkit/components/autocomplete/nsAutoCompleteController.cpp
>@@ -1461,47 +1566,21 @@ nsAutoCompleteController::CompleteValue(
>-    if (NS_SUCCEEDED(ios->ExtractScheme(NS_ConvertUTF16toUTF8(aValue), scheme))) {
..
>+    // Autocompleting something from the middle.
>+    // Use the format "searchstring >> full string" to indicate to the user
>+    // what we are going to replace their search string with.
>+    mInput->SetTextValue(mSearchString + NS_LITERAL_STRING(" >> ") + aValue);
>+    endSelect = mSearchString.Length() + 4 + aValue.Length();

Comment 1

[Asa Dotzler [:asa]]

with the feature pulled we don't need to track for Firefox 6.

Comment 2

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.