Closed
Bug 659693
Opened 14 years ago
Closed 14 years ago
domain highlighting doesn't work with IPv6 literals
Categories
(Firefox :: Address Bar, defect)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
Firefox 7
Tracking | Status | |
---|---|---|
firefox6 | --- | fixed |
People
(Reporter: bws42, Assigned: dao)
References
()
Details
Attachments
(1 file)
1.87 KB,
patch
|
sdwilsh
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110525 Firefox/7.0a1
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110525 Firefox/7.0a1
The domain highlighting feature added as part of bug 451833 fails to properly highlight the entire IPv6 address; it stops after the first colon.
Reproducible: Always
Reporter | ||
Comment 1•14 years ago
|
||
There's an example URL in the URL field, it might not work for you as it's a local IPv6 address, but it demonstrates the problem fine.
Blocks: 451833
Version: unspecified → Trunk
Assignee | ||
Comment 2•14 years ago
|
||
This uses (.+?) for the host instead of ([^\/:]+), which caused this bug by excluding the colon. Since question mark makes .+ nongreedy, (?::\d+)?(?:\/|$) is needed to ensure that the host is followed by an optional port and a slash or the end of the string.
Assignee: nobody → dao
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #535139 -
Flags: review?(sdwilsh)
Comment 3•14 years ago
|
||
Comment on attachment 535139 [details] [diff] [review]
patch
I sure do hate me some regular expressions. r=sdwilsh
Attachment #535139 -
Flags: review?(sdwilsh) → review+
Assignee | ||
Comment 4•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
status-firefox6:
--- → affected
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7
Assignee | ||
Updated•14 years ago
|
Flags: in-testsuite+
Assignee | ||
Updated•14 years ago
|
Attachment #535139 -
Flags: approval-mozilla-aurora?
Comment 6•14 years ago
|
||
In the failure case, was the whole domain "graytext" or was it all "black text"?
Reporter | ||
Comment 7•14 years ago
|
||
In the failure case the address was only black to the first colon. So given an address like dead:beef:1234::1 dead was black and the rest was not.
Updated•14 years ago
|
Attachment #535139 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 8•14 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•