659693 - domain highlighting doesn't work with IPv6 literals

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Will Roberts [:bws42]]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110525 Firefox/7.0a1
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110525 Firefox/7.0a1

The domain highlighting feature added as part of bug 451833 fails to properly highlight the entire IPv6 address; it stops after the first colon.

Reproducible: Always

Comment 1

[Will Roberts [:bws42]]

There's an example URL in the URL field, it might not work for you as it's a local IPv6 address, but it demonstrates the problem fine.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

This uses (.+?) for the host instead of ([^\/:]+), which caused this bug by excluding the colon. Since question mark makes .+ nongreedy, (?::\d+)?(?:\/|$) is needed to ensure that the host is followed by an optional port and a slash or the end of the string.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 535139 [details] [diff] [review]
patch

I sure do hate me some regular expressions.  r=sdwilsh

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/80356fecf627

Comment 5

[Will Roberts [:bws42]]

Verified it works as expected.

Comment 6

[Asa Dotzler [:asa]]

In the failure case, was the whole domain "graytext" or was it all "black text"?

Comment 7

[Will Roberts [:bws42]]

In the failure case the address was only black to the first colon. So given an address like dead:beef:1234::1 dead was black and the rest was not.

Comment 8

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-aurora/rev/611741a1dedd