Closed Bug 659728 Opened 9 years ago Closed 9 years ago
Android app menu layout broken in Gingerbread theme with >4 items
64.86 KB, image/png
53.29 KB, image/png
58.70 KB, image/png
6.66 KB, application/zip
6.84 KB, patch
|Details | Diff | Splinter Review|
Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110525 Firefox/7.0a1 Fennec/7.0a1 Device: HTC Flyer OS: Android 2.2 1. Hit the menu option for the on the Flyer after loading Fennec Expected: Squares are even and the wording is readable on the bottom row Actual: the lettering is off and there's no symmetry; See Screenshot
(In reply to comment #0) > Fennec/7.0a1 > Device: HTC Flyer > OS: Android 2.2 Android 2.2? The Gingerbread Theme should be for 2.3 or higher > 1. Hit the menu option for the on the Flyer after loading Fennec > > Expected: Squares are even and the wording is readable on the bottom row > Actual: the lettering is off and there's no symmetry; See Screenshot * I see "Quit Firefox" is installed. Can you uninstall and try again? * Can you test on Firefox 5 Beta 2 and see if the old theme has the same problem?
tracking-fennec: --- → ?
Component: General → Extension Compatibility
QA Contact: general → extension-compatibility
Summary: Menu Options need UI Tweak for Gingerbread theme → Android app menu layout broken in Gingerbread theme with >4 items
I disabled quit and itis more legible. The spacing is a bit tight. see new attachment
Fennec 5b2 seems to be ok. See screenshot.
Forgot to mention, I had the wrong text for the OS version: should be OS: 2.3
(In reply to comment #3) > Created attachment 535167 [details] > Fennec 5b2 > > Fennec 5b2 seems to be ok. See screenshot. Based on this, I am assuming the image size change in the app menu icons is to blame. The old theme used 42px images and the new gingerbread theme uses 48px images. We could always use 42px images (making it a bit easier for add-ons) or we could update the sizing in the menu to better accommodate the larger size. If we keep the larger size and an add-on doesn't support both sizes, it would potentially create an unbalanced look.
(In reply to comment #5) > If we keep the larger size and an add-on doesn't support both sizes, it > would potentially create an unbalanced look. If we do keep the larger size for Gingerbread, we can add padding to the Froyo image files so that the PNGs are the same size even if the icons aren't. Then add-ons can provide a single PNG that will at least keep the same layout with either skin. (It would still be difficult for add-ons to actually look consistent with both skins -- for add-on compatibility, it would be best to just use the old icon size in both.)
mbrubeck: For the sake of visual consistency (and simplicity), let's go back to using icons at the old size (42x42). I'm making new ones and will post them shortly.
Updated icons attached :)
Simple replacement patch
Assignee: nobody → mark.finkle
Attachment #535184 - Flags: review?(mbrubeck)
tracking-fennec: ? → 6+
This still needs approval to land in Aurora for Firefox 6; it is a regression compared to Firefox 5 and affects several add-ons, including one of our most popular featured add-ons.
Attachment #535184 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed to Aurora for Firefox 6: http://hg.mozilla.org/releases/mozilla-aurora/rev/f5ab57ebf2da
Verified for Nightly : Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110527 Firefox/7.0a1 Fennec/7.0a1 Device: HTC Flyer OS: Android 2.3
9 years ago
Mozilla/5.0 (Android; Linux armv71; rv6.0a2) Gecko/20110623 Firefox/6.0a2 Fennec/6.0a2 Device: HTC Flyer OS: Android 2.3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.