65975 - News: opening multiple connections and not closing them for particular server

Status: VERIFIED FIXED

(MailNews Core :: Networking: NNTP, defect)

Description

[David :Bienvenu]

A user has reported that for one particular news server, we're opening a
connection per news message read, and not closing any of them down, so he runs
out of connections quickly. I'll attach a protocol log when I can get one. The
users' e-mail address is [e-mail]

Comment 1

[Blake Ross]

Some people on IRC were having this problem with n.p.m.*

Comment 2

[David :Bienvenu]

Did they see it on news.mozilla.org, or on some other server where those groups
are replicated?

Comment 3

[David :Bienvenu]

Attachment: proposed fix for news posting

Comment 4

[David :Bienvenu]

I believe the problem here is that we're always opening a new connection for
every news posting you make, and never cleaning up that connection. The fix is
to look in the connection cache for a connection to use when posting a news
message. We should look at fixing the news protocol state machine to not allow
more than N open connections (i.e., closing connections instead of leaving them
in the cache if the cache is full).

Comment 5

[David :Bienvenu]

*** Bug 66065 has been marked as a duplicate of this bug. ***

Comment 6

[(not reading, please use [e-mail] instead)]

r=sspitzer

check that bad boy in.

http://bugzilla.mozilla.org/show_bug.cgi?id=66150 logged to track the other
issue you raised.

Comment 7

[Blake Ross]

(bienvenu: news.mozilla.org, if it still matters)

Comment 8

[David :Bienvenu]

hey, Scott, can I get an sr= when you get a chance? thanks!

Comment 9

[Scott MacGregor]

sr=mscott

Comment 10

[David :Bienvenu]

fix checked in.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

Bienvenu - can I verify this with some more NTTP log fun? :-)  If so, tell me
what I'm looking for or not looking for, and I'll check this out.  Thanks.

Comment 12

[David :Bienvenu]

yes, you'll be looking for the absence of new connections getting made for each
posting - new connections show up in the log as the greeting response from the
server, usually.

You can also use netstat to see how many open connections you have to the news
server. You should really only have one.

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Log showing our connections opened during read of two messages.

Comment 14

[David :Bienvenu]

Stephen, I think this bug is about doing news postings, not so much reading
messages as I originally thought. So you should generate a log of a session when
you post several news messages.

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Attempted to post 3 messages, only managed to post 2.

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

notice the 0[2f3fd0]: Receiving: 400 Too_Many_Connections
error.  I got this on my 3rd attempt at posting, it never went through.  Windows
2000, build 2001012205.

Comment 17

[[e-mail] (gone - use [e-mail] instead)]

Attachment: This time, I took it slower, and didn't get the same error on Mac.

Comment 18

[David :Bienvenu]

Stephen, my fix won't show up until tomorrow's build.

Comment 19

[[e-mail] (gone - use [e-mail] instead)]

arrgg... ;-) I hate it when that happens.

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

I apologize for my NNTP log reading not being up to par, but here's what I 
found.  I'll attach a logfile, for Win32.  Also, when I opened up netstat, I 
found it wouldn't update in real time, and by the time it displayed my NNTP 
listening and receiving ports, it was as follows:

stephend:3044 secnews1.mcom.com:nnttp (I did a netstat -n and it was indeed 
port 119)
stephend:3055 secnews1.mcom.com:nntp (119)

Comment 21

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Build 1-23-04, Windows NT 4.0

Comment 22

[David :Bienvenu]

Looks OK - you'll notice that in yesterday's build, before each post, there was
a server greeting:

200 secnews.netscape.com Netscape-Collabra/3.52 03615 NNRP ready (posting ok).

this means we made a new connection to the news server.

In today's log, there is *not* a server greeting response before each post.

Comment 23

[[e-mail] (gone - use [e-mail] instead)]

Thanks for the clarification David, I'll check Mac and Linux now.

Comment 24

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED on Windows NT 4.0, Build 1-23-04
, Mac 2001-01-23-11.  I'll mark this VERIFIED when I figure out the Linux log
file stuff ;-).

Comment 25

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED on Linux, build 2001012506.