document.open("text/plain") broken with HTML5 parser

RESOLVED FIXED in mozilla10

Status

()

Core
HTML: Parser
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: hsivonen)

Tracking

Trunk
mozilla10
x86
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

6 years ago
And apparently, nobody noticed. Not sure if we want to fix at this point?
I think we do need to fix this, yes.  At least as of a few years ago, this feature was still used in various cases...

How did the html5 parser manage to break this?  :(
(Reporter)

Comment 2

6 years ago
http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5Parser.h#186
(Assignee)

Comment 3

6 years ago
Created attachment 536290 [details] [diff] [review]
Support text/plain with document.open

(In reply to comment #0)
> And apparently, nobody noticed. Not sure if we want to fix at this point?

Chrome doesn't support this, either, but since Opera and IE do, let's fix this.
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #536290 - Flags: review?(jonas)
(Assignee)

Updated

6 years ago
Depends on: 479959
Flags: in-testsuite?
Can we add a test too?
(Assignee)

Comment 5

6 years ago
Created attachment 536571 [details] [diff] [review]
Reftests

(In reply to comment #4)
> Can we add a test too?

Yeah, just ran out of time yesterday.
Attachment #536571 - Flags: review?(bzbarsky)
(Assignee)

Comment 6

6 years ago
Created attachment 536572 [details] [diff] [review]
Reftest, with one more test
Attachment #536571 - Attachment is obsolete: true
Attachment #536571 - Flags: review?(bzbarsky)
Attachment #536572 - Flags: review?(bzbarsky)
Comment on attachment 536572 [details] [diff] [review]
Reftest, with one more test

r=me
Attachment #536572 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 8

6 years ago
Created attachment 567088 [details] [diff] [review]
Support text/plain with document.open, rebased
Attachment #536290 - Attachment is obsolete: true
Attachment #536290 - Flags: review?(jonas)
Attachment #567088 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Attachment #567088 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 9

6 years ago
Thanks for the reviews. Landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f09b3ca76707
https://hg.mozilla.org/integration/mozilla-inbound/rev/804eb7a2a0c7
Flags: in-testsuite? → in-testsuite+
Target Milestone: --- → mozilla10
https://hg.mozilla.org/mozilla-central/rev/f09b3ca76707
https://hg.mozilla.org/mozilla-central/rev/804eb7a2a0c7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.