659763 - document.open("text/plain") broken with HTML5 parser

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And apparently, nobody noticed. Not sure if we want to fix at this point?

Comment 1

[Boris Zbarsky [:bzbarsky]]

I think we do need to fix this, yes.  At least as of a few years ago, this feature was still used in various cases...

How did the html5 parser manage to break this?  :(

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5Parser.h#186

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Support text/plain with document.open

(In reply to comment #0)
> And apparently, nobody noticed. Not sure if we want to fix at this point?

Chrome doesn't support this, either, but since Opera and IE do, let's fix this.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Can we add a test too?

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: Reftests

(In reply to comment #4)
> Can we add a test too?

Yeah, just ran out of time yesterday.

Comment 6

[Henri Sivonen (:hsivonen)]

Attachment: Reftest, with one more test

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 536572 [details] [diff] [review]
Reftest, with one more test

r=me

Comment 8

[Henri Sivonen (:hsivonen)]

Attachment: Support text/plain with document.open, rebased

Comment 9

[Henri Sivonen (:hsivonen)]

Thanks for the reviews. Landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f09b3ca76707
https://hg.mozilla.org/integration/mozilla-inbound/rev/804eb7a2a0c7

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f09b3ca76707
https://hg.mozilla.org/mozilla-central/rev/804eb7a2a0c7