65987 - Need to implement the current() XSLT function

Status: VERIFIED FIXED

(Core :: XSLT, defect)

Description

[Peter Van der Beken [:peterv]]

We need to implement the current() XSLT extension function
(http://www.w3.org/TR/xslt.html#function-current) in Transformiix.

Comment 1

[Keith Visco]

Checked in implementation.

Comment 2

[Peter Van der Beken [:peterv]]

I'm doubtful about the current (hehe) implementation.

Comment 3

[Keith Visco]

Do we have a test case for this?

Comment 4

[Axel Hecht]

I'll attach the xml-xalan test case for this.
And yes, it's done wrong at the moment

Axel

Comment 5

[Axel Hecht]

Attachment: xml file

Comment 6

[Axel Hecht]

Attachment: xsl file

Comment 7

[Axel Hecht]

Attachment: reference solution

Comment 8

[Keith Visco]

Thanks Axel...I'll have this working ASAP...probably tonight.

--Keith

Comment 9

[Axel Hecht]

I wonder if we have some stack of context nodes. and if current() would be
the very first one, instead of the top one.

Axel

Comment 10

[Keith Visco]

Judging from the output it looks as if current is the context node used at the 
start of the evaluating the expression.

Should be a quick fix. I just don't have the code in front of me until I go 
home.


--Keith

Comment 11

[Keith Visco]

I just looked at XSL:P and had the same bug....so I fixed it for that. It was a 
quick fix. I'll do the same for Transformiix tonight. 

--Keith

Comment 12

[Keith Visco]

Attachment: Patch for current()

Comment 13

[Keith Visco]

The test cases are now working properly. Axel or Peter, please verify.

Thanks,

--Keith

Comment 14

[Peter Van der Beken [:peterv]]

Looks ok to me (Keith, could you use cvs diff -u in the future?). r=peterv.

Comment 15

[Axel Hecht]

r=me, had to add $(srcdir)/../util to xslt/functions/Makefile.in and gave the
makefile.win an overwhaul, too, of course adding -I..\util there.

Checking in

Axel

Comment 16

[Peter Van der Beken [:peterv]]

Verified.