659908 - transient_current_max_pages incorrectly set

Status: RESOLVED INVALID

(Toolkit :: Places, defect)

Description

[Thomas Bertels]

The pref places.history.expiration.transient_current_max_pages value seems to be incorrectly set here.

PC: single core processor with 1.5 GiB of memory.
places.database.cache_to_memory_percentage value is 6
The value of memsize as returned by @mozilla.org/system-info;1 [2] is 1610072064

Based on that and the code [1], this._urisLimit should be:
1610072064 * 6 / 100 / 2000 = 48302

However, the current value is set to 32201, which means 1 GiB of memory.

I tried setting and removing places.history.expiration.max_pages several times, transient_current_max_pages always goes back to 32201.

Reproduced with Firefox 4 and on the trunk.

[1] http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/nsPlacesExpiration.js#742
[2] http://mxr.mozilla.org/mozilla-central/source/xpcom/tests/unit/test_systemInfo.js#40

Comment 1

[Marco Bonardo [:mak]]

you are dividing by 2000 that is the value for more than 1 core, if you divide by 3000 you get 32201.