Remove leftover MOZ_IPC ifdef in nsHttpChannel.cpp

RESOLVED FIXED in mozilla7

Status

()

Core
Networking: HTTP
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#48

> 48 #ifdef MOZ_IPC
> 49 #include "base/basictypes.h"
> 50 #endif 

MOZ_IPC is no longer defined as of bug 639754, so basictypes.h is no longer included even though it used to be. Since nothing broke shall I just remove it? Or should I remove just the ifdef, thereby restoring the include?
Created attachment 535385 [details] [diff] [review]
Remove dead code

Three line change.

Thanks :-)
Attachment #535385 - Flags: review?(cbiesinger)
Meant to add: I decided to go with the 'just remove it' approach. Please let me know if the alternative is desired instead.
Not exactly a risky patch, but seeing as I was pushing to try anyway...
http://dev.philringnalda.com/tbpl/?tree=Try&rev=814ab5d45c97
Attachment #535385 - Flags: review?(cbiesinger) → review+
Created attachment 538388 [details] [diff] [review]
Remove dead code

Only change is adding the patch author field, which hg missed off despite my hgrc. Carrying forwards r+.

Has passed try (comment 3); author & commit message filled out.
Thanks to whomever checks it in :-)
Attachment #535385 - Attachment is obsolete: true
Attachment #538388 - Flags: review+
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/29f87a9792ec
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.