Closed
Bug 659944
Opened 14 years ago
Closed 14 years ago
Remove leftover MOZ_IPC ifdef in nsHttpChannel.cpp
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.10 KB,
patch
|
emorley
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/http/nsHttpChannel.cpp#48
> 48 #ifdef MOZ_IPC
> 49 #include "base/basictypes.h"
> 50 #endif
MOZ_IPC is no longer defined as of bug 639754, so basictypes.h is no longer included even though it used to be. Since nothing broke shall I just remove it? Or should I remove just the ifdef, thereby restoring the include?
|
Assignee | |
Comment 1•14 years ago
|
||
Three line change.
Thanks :-)
Attachment #535385 -
Flags: review?(cbiesinger)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Meant to add: I decided to go with the 'just remove it' approach. Please let me know if the alternative is desired instead.
|
|
Assignee | |
Comment 3•14 years ago
|
||
Not exactly a risky patch, but seeing as I was pushing to try anyway...
http://dev.philringnalda.com/tbpl/?tree=Try&rev=814ab5d45c97
|
||
Updated•14 years ago
|
Attachment #535385 -
Flags: review?(cbiesinger) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Only change is adding the patch author field, which hg missed off despite my hgrc. Carrying forwards r+.
Has passed try (comment 3); author & commit message filled out.
Thanks to whomever checks it in :-)
Attachment #535385 -
Attachment is obsolete: true
Attachment #538388 -
Flags: review+
|
|
Assignee | |
Updated•14 years ago
|
Keywords: checkin-needed
|
||
Comment 5•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•