659958 - Weekly Planner and Monthly Grid print formats are broken [Error: calendarDefaultTimezone is not defined] [Error: ASSERT is not defined]

Status: RESOLVED FIXED

(Calendar :: Printing, defect)

Description

[Stefan Sitter [:ssitter]]

Lightning 1.0b4pre (20110526) with Mozilla/5.0 (Windows NT 6.1; rv:5.0) Gecko/20110526 Thunderbird/3.3a4pre

Weekly Planner and Monthly Grid print formats are broken [Error: calendarDefaultTimezone is not defined] [Error: ASSERT is not defined]

Steps to reproduce:
1) Switch to calendar tab and select events that you want to print
2) Select menu File > Print
3) In the print preview dialog set the print format to Weekly Planner or Monthly

Actual results:
Print preview will show only blank. Error Console shows different errors depending on the selected format:

Error: ASSERT is not defined
Source file: file:///C:/[...]/calendar-js/calWeekPrinter.js
Line: 128


Error: calendarDefaultTimezone is not defined
Source file: file:///C:/[...]/calendar-js/calMonthGridPrinter.js
Line: 303

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Thanks for finding this! All we need to do is prefix those functions with cal.

Comment 2

[Stefan Sitter [:ssitter]]

Attachment: patch

Patch restores basic functionality. After fixing the initial errors more errors were reported. An interesting error was "item is not defined" in the for each loop caused by variable redefinition:
    for each (let item in sortedList) {
        let sDate = item.startDate... // raised error item is not defined   
        ...
        let item = <tr>... // because variable with same name is declared later
    }

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 535827 [details] [diff] [review]
patch

r=philipp with one more change:

diff -r fbe3582252ec calendar/import-export/calOutlookCSVImportExport.js
--- a/calendar/import-export/calOutlookCSVImportExport.js	Sat May 28 00:50:00 2011 +0200
+++ b/calendar/import-export/calOutlookCSVImportExport.js	Mon May 30 11:34:03 2011 +0200
@@ -386,7 +386,7 @@
                     if ("categoriesIndex" in args) {
                         txt = this.parseTextField(eventFields[args.categoriesIndex])
                         if (txt) {
-                            let categories = categoriesStringToArray(txt);
+                            let categories = cal.categoriesStringToArray(txt);
                             event.setCategories(categories.length, categories);
                         }
                     }

Comment 4

[Stefan Sitter [:ssitter]]

Sorry, I don't see how your review comment is connected to my patch. categoriesStringToArray() is used without cal prefix in all code locations: http://mxr.mozilla.org/comm-central/search?string=categoriesStringToArray&find=/calendar/

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

You're right, this is not technically connected with printing. I was checking for other functions from calUtils not used with the cal prefix in the import-export folder, since the files here don't load calUtils.js via subscript loader.

Feel free to check in without change and I'll whip up a separate patch (comm-central + comm-miramar).

Comment 6

[Stefan Sitter [:ssitter]]

Setting checkin-needed. Seems my checkin rights have been disabled and I need to get them re-activated first.

Comment 7

[Stefan Sitter [:ssitter]]

Comment on attachment 535827 [details] [diff] [review]
patch

Pushed to https://hg.mozilla.org/comm-central/rev/4f695a99301c
Pushed to https://hg.mozilla.org/releases/comm-miramar/rev/6c73f013e59e