The default bug view has changed. See this FAQ.

OpenType sanitizer needs to handle 'name' table, not just replace it

RESOLVED FIXED in mozilla7

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

Trunk
mozilla7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 535479 [details] [diff] [review]
patch, support the 'name' table in OTS

Currently, OTS discards the 'name' table and inserts a set of fixed name strings in all sanitized fonts. This prevents us returning the proper font name when querying the fonts actually used to render content (see bug 467669).

The attached patch fixes this by parsing and serializing the table, so that the font name is not lost during sanitization.

(When we're happy the patch is reasonable, we should submit it upstream to the OTS project.)
(Assignee)

Updated

6 years ago
Assignee: nobody → jfkthame
Blocks: 467669
(Assignee)

Updated

6 years ago
Attachment #535479 - Flags: review?(jdaggett)
Attachment #535479 - Attachment is patch: true
Attachment #535479 - Attachment mime type: text/x-patch → text/plain
(Assignee)

Comment 1

6 years ago
I filed this as a feature request in the Chromium tracker, and have just attached the patch there as well to see what they do with it.

http://code.google.com/p/chromium/issues/detail?id=83706

Comment 2

6 years ago
Comment on attachment 535479 [details] [diff] [review]
patch, support the 'name' table in OTS

Code looks reasonable but as I mentioned on IRC I'm still not convinced that all this name table data is really necessary.  It seems like the only data that we currently would need is the fullname data but we're bringing in all name data fields.  But I'm guessing web font vendors are stripping a lot of name table entries so I guess we can adjust this later if it seems to be causing a problem.
Attachment #535479 - Flags: review?(jdaggett) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/a4659906bcfb
Whiteboard: [inbound]
(Assignee)

Comment 4

6 years ago
This was backed out along with bug 467669 in
http://hg.mozilla.org/integration/mozilla-inbound/rev/ed3cf3967b69
Whiteboard: [inbound]
(Assignee)

Comment 5

6 years ago
And relanded on m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/2d24929f1d65
Whiteboard: [inbound]
Merged in m-c:
http://hg.mozilla.org/mozilla-central/rev/2d24929f1d65
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
Depends on: 700057
You need to log in before you can comment on or make changes to this bug.