Closed
Bug 660109
Opened 15 years ago
Closed 14 years ago
Allow to distinguish History removals caused by expiration from those requested by the user
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: mak, Assigned: mak)
References
Details
(Whiteboard: [places-next-wanted][fixed-in-places])
Attachments
(1 file, 2 obsolete files)
|
19.09 KB,
patch
|
Details | Diff | Splinter Review |
Syncing mobile or a netbook with desktop may cause history loss on the desktop since expiration limits are different.
We should allow Sync to distinguish removals and ignore expiration removals.
|
Assignee | |
Updated•15 years ago
|
Summary: Allow Sync to distinguish expiration onDeleteURI from user-activated ones → Allow Sync to distinguish onDeleteURI caused by expiration from the user-activated ones
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•15 years ago
|
Flags: in-testsuite?
Summary: Allow Sync to distinguish onDeleteURI caused by expiration from the user-activated ones → Allow to distinguish History removals caused by expiration from those requested by the user
|
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #541478 -
Flags: review?(dietrich)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #541480 -
Flags: review?(dietrich)
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [places-next-wanted] → [places-next-wanted][needs-sr]
|
||
Comment 3•15 years ago
|
||
Comment on attachment 541480 [details] [diff] [review]
patch v1.0
Review of attachment 541480 [details] [diff] [review]:
-----------------------------------------------------------------
looks ok, r=me
Attachment #541480 -
Flags: review?(dietrich) → review+
|
|
||
Comment 4•15 years ago
|
||
Comment on attachment 541478 [details] [diff] [review]
tests v1.0
Review of attachment 541478 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #541478 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Comment on attachment 541480 [details] [diff] [review]
patch v1.0
Thanks! This needs SR, I'm not much worried by changing the API at this point, since it's the same exact methods and interfaces we changed in this same release for GUIDs (and I think we should try to also fix bug 662806 in the same release, to coalesce changes to this interface)
Attachment #541480 -
Flags: superreview?(robert.bugzilla)
|
||
Updated•15 years ago
|
Attachment #541480 -
Flags: superreview?(robert.bugzilla) → superreview+
|
|
Assignee | |
Comment 6•15 years ago
|
||
Coalesced patch, to simplify landing.
Attachment #541478 -
Attachment is obsolete: true
Attachment #541480 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•14 years ago
|
||
Whiteboard: [places-next-wanted][needs-sr] → [places-next-wanted][fixed-in-places]
|
|
Assignee | |
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
|
|
Assignee | |
Updated•14 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•