660159 - Make uploads of length greater than 2^32 work

Status: RESOLVED DUPLICATE of bug 215450

(Core :: Networking: HTTP, defect)

Description

[Mark Nottingham]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_7; en-au) AppleWebKit/533.21.1 (KHTML, like Gecko) Version/5.0.5 Safari/533.21.1
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1)

Doing a form upload of a large file (in this case, a Fedora ISO), gives:

POST /cgi-bin/run/~jkorpela/echo.cgi HTTP/1.1
Host: www.cs.tut.fi
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-gb,en;q=0.5
Accept-Encoding: gzip, deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
DNT: 1
Connection: keep-alive
Content-Type: multipart/form-data; boundary=---------------------------168072824752491622650073
Content-Length: -698656418

Notice the negative Content-Length.

Reproducible: Always

Comment 1

[Boris Zbarsky [:bzbarsky]]

nsIUploadChannel only allows 32-bit content lengths.

We should probably fix that.

However nsIInputStream.available is also 32-bit, so a whole bunch of other stuff would need to get fixed to make this actually work.

I'm sort of surprised I don't see any existing tracking bugs on this...

Comment 2

[Patrick McManus [:mcmanus]]

(In reply to comment #1)

> I'm sort of surprised I don't see any existing tracking bugs on this...

see bug 215450

though I think we should keep this one open and more quickly fix the fact that we apparently try and proceed anyhow with the out of range value and produce that negative content length.

Comment 4

[Philip Molter]

When I upload a file >2**32 in size, I actually don't get a negative content length.  I get a small positive content-length.  An example file I used is debian-6.0.3-amd64-DVD-2.iso, found here:

http://mirror.yellowfiber.net/debian-cd/6.0.3/amd64/iso-dvd/debian-6.0.3-amd64-DVD-2.iso

When I upload this ISO, I get a small Content-Length of 221-227 bytes.  I'm sure this length depends somewhat on the boundary name generated.