Closed Bug 660200 Opened 13 years ago Closed 13 years ago

Intermittent failure in content/html/content/test/test_bug514437.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - onFormSubmission is not defined

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: mounir, Assigned: mounir)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Patch v1
2.79 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
Mounir, please stop writing flaky tests!

s: talos-r3-xp-038
56296 ERROR TEST-UNEXPECTED-FAIL | /tests/content/html/content/test/test_bug514437.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - onFormSubmission is not defined at http://mochi.test:8888/tests/content/html/content/test/test_bug514437.html:1

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1306491100.1306492880.2737.gz&fulltext=1
Sorry Mounir, I'm on it! :(
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
<iframe name="submit_frame" onload="onFormSubmission();" style="visibility: hidden;"></iframe> before the declaration of onFormSubmission() is badness.
(In reply to comment #2)
> <iframe name="submit_frame" onload="onFormSubmission();" style="visibility:
> hidden;"></iframe> before the declaration of onFormSubmission() is badness.

Indeed. And even more because I only want onForSubmission() to be called after form.submit().
Attached patch Patch v1 — — Splinter Review 

        Attachment #535613 -
        Flags: review?(ehsan)

    
  
Whiteboard: [orange] → [orange][needs review]

    
    

    
  
Comment on attachment 535613 [details] [diff] [review]
Patch v1

Mounir, thanks for quickly fixing this flaky test!  :-)

        Attachment #535613 -
        Flags: review?(ehsan) → review+

    
    

    
      
  

    
  
Flags: in-testsuite+
Whiteboard: [orange][needs review] → [orange][fixed in cedar]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/12ee31e36c0f
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed in cedar] → [orange]
Target Milestone: --- → mozilla7
Whiteboard: [orange]

          You need to log in
          before you can comment on or make changes to this bug.