Closed Bug 660326 Opened 13 years ago Closed 13 years ago

send java exceptions to crash-stats

Categories

(Core Graveyard :: Widget: Android, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla7

People

(Reporter: blassey, Assigned: blassey)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
      No description provided.
Attachment #535725 - Flags: review?(doug.turner)
Comment on attachment 535725 [details] [diff] [review]
patch


>+                } catch (Exception e) {
>+                    Log.e("GeckoApp", "top level exception", e);
>+                    ByteArrayOutputStream baos = new ByteArrayOutputStream();
>+                    PrintStream ps = new PrintStream(baos);
>+                    e.printStackTrace(ps);
>+                    GeckoAppShell.reportJavaCrash(baos.toString());
>+                }

StringWriter instead of a ByteArrayOutputStream looks to be much more common.


>+                } catch (Exception e) {
>+                    Log.e("GeckoApp", "top level exception", e);
>+                    ByteArrayOutputStream baos = new ByteArrayOutputStream();
>+                    PrintStream ps = new PrintStream(baos);
>+                    e.printStackTrace(ps);
>+                    GeckoAppShell.reportJavaCrash(baos.toString());
>+                }
>+            }
>+        });

same.

Also, maybe reportJavaCrash should just take the Exception, and call it reportJavaUnhandledException?  Maybe it could take a flag if you want to abort or not.

toss one more up.



Also, ping the server folks and let them know how we are going to pass this data.  not sure if there will be any other request.
Attachment #535725 - Flags: review?(doug.turner) → review-
Attached patch patchSplinter Review
Assignee: nobody → blassey.bugs
Attachment #535725 - Attachment is obsolete: true
Attachment #536647 - Flags: review?(doug.turner)
Comment on attachment 536647 [details] [diff] [review]
patch

discussed.  exceptions are hard over JNI.

did you discuss with server ops people?
Attachment #536647 - Flags: review?(doug.turner) → review+
pushed http://hg.mozilla.org/mozilla-central/rev/54f7bd940f82
(In reply to comment #4)
> Comment on attachment 536647 [details] [diff] [review] [review]
> did you discuss with server ops people?

Yes, and it was on their agenda to discuss in today's meeting:
https://wiki.mozilla.org/Breakpad/Status_Meetings/2011-June-1#Other_issues
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Depends on: 661472
Can anyone please provide some guidelines that I can use to verify this? Do I need to create any specific environment to test it?

Thanks!
We have seen examples of Java stack traces in socorro reports, so this is verified.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.