The default bug view has changed. See this FAQ.

[l20n] Separate object referencing and attribute referencing expression

RESOLVED FIXED

Status

()

Core
Internationalization
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: gandalf, Assigned: gandalf)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Historically we had no way to separate object value properties expression and entity attribute expressions.

I decided to separate them using the following notion:

object value property expression:
 - computed: identifier[property]
 - not computed: identifier.property

entity attribute expression:

 - computed: identifier[.property]
 - not computed: identifier..property

I'm going to attach a patch against silme AST and parser that shows the proposed changes.
(Assignee)

Updated

6 years ago
Assignee: smontagu → gandalf
OS: Mac OS X → All
(Assignee)

Comment 1

6 years ago
Created attachment 535755 [details] [diff] [review]
patch

requesting feedback from Axel.

I'm changing the way Idref works (removing multipart Idrefs in favor of nested Indexes)

I'm reusing the AST model from JS with their MemberExpressions with computed property.
Despite allowing for nested combinations (obj..attr.prop or obj[.obj2..attr2]) it also gives serializer ability to recognize the way ObjectIndex is being used depending on it's computed value.
Attachment #535755 - Flags: feedback?(l10n)
(Assignee)

Updated

6 years ago
Attachment #535755 - Attachment is patch: true
Attachment #535755 - Attachment mime type: text/x-patch → text/plain
(Assignee)

Updated

5 years ago
Attachment #535755 - Flags: feedback?(l10n)
(Assignee)

Comment 2

5 years ago
fixed long ago in the l20n python tree
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.