660382 - Hide the complex features of custom search by default

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Max Kanat-Alexander]

Right now, the new custom search stuff has a lot of UI -- the Not stuff, the + button, the "ALL" vs "ANY" select, the parentheses buttons, the two drop downs, and the text box.

I think that by default, it would be nice if the parentheses buttons and the Not stuff was hidden by default and only showed up if somebody selected that it should (based on TUI).

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Requires the blocker patch. This patch is pretty simple.

Comment 2

[Frédéric Buclin]

Does this bug block 4.2?

Comment 3

[Max Kanat-Alexander]

(In reply to comment #2)
> Does this bug block 4.2?

  Only in the sense that it will be approved for branch checkin if there is a branch. It's not a hard blocker.

Comment 4

[David Lawrence [:dkl]]

[dkl@localhost trunk]$ patch -p0 < ~/Downloads/search-custom-advanced.diff 
patching file js/custom-search.js
patching file template/en/default/search/boolean-charts.html.tmpl
Hunk #2 FAILED at 83.
1 out of 4 hunks FAILED -- saving rejects to file template/en/default/search/boolean-charts.html.tmpl.rej
[dkl@localhost trunk]$ vi template/en/default/search/boolean-charts.html.tmpl.rej

--- template/en/default/search/boolean-charts.html.tmpl 2011-05-27 23:46:07 +0000
+++ template/en/default/search/boolean-charts.html.tmpl 2011-05-28 00:19:32 +0000
@@ -83,7 +85,8 @@

   [% IF !top_level_any_shown %]
     [% INCLUDE any_all_select
-      name = "j_top" id = "j_top" selected = default.j_top %]
+      name = "j_top" id = "j_top" selected = default.j_top 
+      with_advanced_link = with_buttons %]
     [% top_level_any_shown = 1 %]
   [% END %]

Comment 5

[Max Kanat-Alexander]

Attachment: v2

Thanks! Fixed the bitrot and also a bug I found where the Advanced link wouldn't appear if you were editing a search with charts in it where the first chart wasn't f0.

Comment 6

[David Lawrence [:dkl]]

Attachment: Broken hide advanced features link when adding search criteria (screenshot)

Attaching screenshot showing that the Hide Advanced Features link is not being removed properly and is in fact being repeated over and over.

dkl

Comment 7

[Max Kanat-Alexander]

Comment on attachment 537674 [details] [diff] [review]
v2

Ach, thanks.

Comment 8

[Max Kanat-Alexander]

Attachment: v3

Okay, fixed now.

Comment 9

[David Lawrence [:dkl]]

Comment on attachment 546890 [details] [diff] [review]
v3

Looks good and works well now. r=dkl

Comment 10

[Frédéric Buclin]

mkanat: I suggest you commit this patch before 4.1.3 as it's ready. :)

Comment 11

[Max Kanat-Alexander]

Committed as revision 7882.

Comment 12

[Frédéric Buclin]

You forgot to fix filterexceptions.pl. 008filter.t was throwing a warning.

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified template/en/default/filterexceptions.pl
Committed revision 7886.