Last Comment Bug 660433 - Remove nsIDOMNSHTMLFormElement, nsIDOMNSHTMLTextAreaElement
: Remove nsIDOMNSHTMLFormElement, nsIDOMNSHTMLTextAreaElement
Status: RESOLVED FIXED
: dev-doc-complete
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-28 03:07 PDT by :Ms2ger (⌚ UTC+1/+2)
Modified: 2011-06-14 06:28 PDT (History)
3 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
textarea (20.98 KB, patch)
2011-05-28 03:07 PDT, :Ms2ger (⌚ UTC+1/+2)
peterv: review+
mounir: feedback+
Ms2ger: checkin+
Details | Diff | Splinter Review
form (8.90 KB, patch)
2011-05-28 03:08 PDT, :Ms2ger (⌚ UTC+1/+2)
peterv: review+
mounir: feedback+
mounir: checkin+
Details | Diff | Splinter Review

Description :Ms2ger (⌚ UTC+1/+2) 2011-05-28 03:07:19 PDT
Created attachment 535835 [details] [diff] [review]
textarea
Comment 1 :Ms2ger (⌚ UTC+1/+2) 2011-05-28 03:08:07 PDT
Created attachment 535836 [details] [diff] [review]
form
Comment 2 Mounir Lamouri (:mounir) 2011-05-30 02:43:04 PDT
Comment on attachment 535836 [details] [diff] [review]
form

Review of attachment 535836 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, f=me

::: dom/interfaces/html/nsIDOMHTMLFormElement.idl
@@ +69,5 @@
>    void                      submit();
>    void                      reset();
> +
> +           attribute DOMString            encoding;
> +  boolean        checkValidity();

Could you put these lines in the same order than the IDL in the WHATWG specs:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#the-form-element

IOW, move encoding after enctype and checkValidity after reset() (with indentation fixes).
Comment 3 Mounir Lamouri (:mounir) 2011-05-30 02:44:39 PDT
Comment on attachment 535835 [details] [diff] [review]
textarea

Review of attachment 535835 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, f=me

::: dom/interfaces/html/nsIDOMHTMLTextAreaElement.idl
@@ +93,5 @@
> +  boolean checkValidity();
> +  void setCustomValidity(in DOMString error);
> +
> +  void                       setSelectionRange(in long selectionStart,
> +                                               in long selectionEnd);

Could you put these new lines in the same order as the WHATWG specs:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element
Comment 4 Peter Van der Beken [:peterv] 2011-05-30 04:24:04 PDT
Comment on attachment 535836 [details] [diff] [review]
form

Review of attachment 535836 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/html/nsIDOMHTMLFormElement.idl
@@ +69,5 @@
>    void                      submit();
>    void                      reset();
> +
> +           attribute DOMString            encoding;
> +  boolean        checkValidity();

Whitespace for checkValidity seems inconsistent with rest of the file.
Comment 6 Peter Van der Beken [:peterv] 2011-06-09 06:11:15 PDT
Comment on attachment 535835 [details] [diff] [review]
textarea

Review of attachment 535835 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/html/nsIDOMHTMLTextAreaElement.idl
@@ +84,5 @@
> +   * "off". "soft" is the default.
> +   */
> +  [Null(Stringify)] attribute DOMString wrap;
> +
> +  // The following lines are parte of the constraint validation API, see:

s/parte/part/
Comment 7 :Ms2ger (⌚ UTC+1/+2) 2011-06-11 09:26:34 PDT
Comment on attachment 535835 [details] [diff] [review]
textarea

http://hg.mozilla.org/mozilla-central/rev/d2bdaef8a701

Note You need to log in before you can comment on or make changes to this bug.