Closed Bug 660433 Opened 9 years ago Closed 9 years ago

Remove nsIDOMNSHTMLFormElement, nsIDOMNSHTMLTextAreaElement

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

(Keywords: dev-doc-complete)

Attachments

(2 files)

Attached patch textareaSplinter Review
No description provided.
Attachment #535835 - Flags: review?(peterv)
Flags: in-testsuite-
OS: Android → All
Attached patch formSplinter Review
Attachment #535836 - Flags: review?(peterv)
Comment on attachment 535836 [details] [diff] [review]
form

Review of attachment 535836 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, f=me

::: dom/interfaces/html/nsIDOMHTMLFormElement.idl
@@ +69,5 @@
>    void                      submit();
>    void                      reset();
> +
> +           attribute DOMString            encoding;
> +  boolean        checkValidity();

Could you put these lines in the same order than the IDL in the WHATWG specs:
http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#the-form-element

IOW, move encoding after enctype and checkValidity after reset() (with indentation fixes).
Attachment #535836 - Flags: feedback+
Comment on attachment 535835 [details] [diff] [review]
textarea

Review of attachment 535835 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, f=me

::: dom/interfaces/html/nsIDOMHTMLTextAreaElement.idl
@@ +93,5 @@
> +  boolean checkValidity();
> +  void setCustomValidity(in DOMString error);
> +
> +  void                       setSelectionRange(in long selectionStart,
> +                                               in long selectionEnd);

Could you put these new lines in the same order as the WHATWG specs:
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-textarea-element
Attachment #535835 - Flags: feedback+
Comment on attachment 535836 [details] [diff] [review]
form

Review of attachment 535836 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/html/nsIDOMHTMLFormElement.idl
@@ +69,5 @@
>    void                      submit();
>    void                      reset();
> +
> +           attribute DOMString            encoding;
> +  boolean        checkValidity();

Whitespace for checkValidity seems inconsistent with rest of the file.
Attachment #535836 - Flags: review?(peterv) → review+
Keywords: dev-doc-needed
Attachment #535836 - Flags: checked-in+ → checkin+
Comment on attachment 535835 [details] [diff] [review]
textarea

Review of attachment 535835 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/html/nsIDOMHTMLTextAreaElement.idl
@@ +84,5 @@
> +   * "off". "soft" is the default.
> +   */
> +  [Null(Stringify)] attribute DOMString wrap;
> +
> +  // The following lines are parte of the constraint validation API, see:

s/parte/part/
Attachment #535835 - Flags: review?(peterv) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.