660493 - list does not update while holding shift-delete

Status: RESOLVED INVALID

(Toolkit :: Autocomplete, defect)

Description

[Joris Debonnet]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

Every now and then, I delete all the history in the little Search box. So I press shift-delete, and wait while I see all those old search terms flash by. 

But that doesn't work anymore since 4.0 - that is to say, the terms are still deleted, but they don't flash by anymore. In other words, the visuel 'blocks' until I release shift-delete, and then it shows the first term that has not yet been deleted (which makes clear that it has been deleting, it just wasn't showing). 

Reproducible: Always

Steps to Reproduce:
1. Press and hold shift-delete in the Search bar

Actual Results:  
Search terms are deleted while visual remains static. 

Expected Results:  
In addition to the actual result, it should be shown that the terms are actually being deleted.

Comment 1

[Alice0775 White]

Confirmed on 
http://hg.mozilla.org/mozilla-central/rev/1f25c65e9335
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110528 Firefox/7.0a1 ID:20110528030702


Regression window(m-c nightly):
Works:
http://hg.mozilla.org/mozilla-central/rev/31ab7a791467
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20090830 Minefield/3.7a1pre ID:20090830050200
Fails:
http://hg.mozilla.org/mozilla-central/rev/d87974838fa9
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a1pre) Gecko/20090831 Minefield/3.7a1pre ID:20090831044843
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=31ab7a791467&tochange=d87974838fa9

In localbuild,
build from 0ebc23cbbf14 : Fails
build from c1972e85e27f : Fails
build from fc2134fff83b : Works
build from 2b834d317457 : Works

Triggered by:
c1972e85e27f	Nickolay Ponomarev — bug 480262 - Deleting an auto-complete entry via shift+backspace(delete) removes last character from the entered text inside a textbox Make the nsAutoCompleteController::HandleDelete() cancel the keypress event if it decides to delete an autocomplete entry. r=gavin

Comment 2

[:Gavin Sharp [email: [e-mail]]]

For what it's worth, you can clear your search bar history using the "Clear Search History" item in the search bar context menu :)

Comment 3

[Joris Debonnet]

You have a point, of course :)

.. upon which I tried that and found one other totally tiny bug (even more tiny than this one). Not sure whether it's related; hope it's okay I add it here. Otherwise: sorry :)


Steps to Reproduce:
1. Make sure there are some entries in the Search Bar suggestions list
2. From an empty Search Bar, press 'arrow down' to get the list and select one of them
3. Right click the Search Bar (containing the term) and choose Clear Search History. The formerly selected term is automatically removed.
4. Press 'arrow down' again. 

Actual Results:  
Upn step 4, you get the list of (deleted) search terms again. You can left/right click it as much as you want and still see it. The list will however disappear upon the first (non-arrow) keydown, or upon blur. 

Expected Results:  
The deleted search terms are in fact deleted, so they shouldn't show.

Comment 4

[roxleitan]

20160604131506 Mozilla/5.0 (Windows NT 5.1; rv:47.0) Gecko/20100101 Firefox/47.0
20160626030213 Mozilla/5.0 (Windows NT 5.1; rv:50.0) Gecko/20100101 Firefox/50.0

I have tested your issue on latest FF release 47.0 and latest Nightly build and could not reproduce it.

Is this still reproducible on your end ? If yes, can you please retest this using latest FF release and latest Nightly build (https://nightly.mozilla.org/) and report back the results ? When doing this, please use a new clean Firefox profile, maybe even safe mode, to eliminate custom settings as a possible cause (https://goo.gl/PNe90E).

Comment 5

[Joris Debonnet]

Looks like this issue is gone! I have another related issue now, but I'll open a new bug for that :)