Last Comment Bug 660524 - Useless use of PromiseFlatString
: Useless use of PromiseFlatString
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla7
Assigned To: neil@parkwaycc.co.uk
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-29 06:00 PDT by neil@parkwaycc.co.uk
Modified: 2011-06-06 20:31 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Proposed patch (1.01 KB, patch)
2011-05-29 06:02 PDT, neil@parkwaycc.co.uk
surkov.alexander: review+
Details | Diff | Splinter Review

Description neil@parkwaycc.co.uk 2011-05-29 06:00:47 PDT
There's no point calling PromiseFlatString on a known flat string, in this case, a literal string.
Comment 1 neil@parkwaycc.co.uk 2011-05-29 06:02:25 PDT
Created attachment 535923 [details] [diff] [review]
Proposed patch
Comment 2 alexander :surkov 2011-05-29 21:47:52 PDT
Comment on attachment 535923 [details] [diff] [review]
Proposed patch

r=me, thank you for doing this
Comment 3 alexander :surkov 2011-06-06 20:31:15 PDT
landed - http://hg.mozilla.org/mozilla-central/rev/4e8a47715c3f

Note You need to log in before you can comment on or make changes to this bug.