Last Comment Bug 660529 - Useless use of PromiseFlatString
: Useless use of PromiseFlatString
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security: PSM (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: ---
Assigned To: neil@parkwaycc.co.uk
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-29 06:16 PDT by neil@parkwaycc.co.uk
Modified: 2011-07-04 14:09 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Proposed patch (1.03 KB, patch)
2011-05-29 06:17 PDT, neil@parkwaycc.co.uk
kaie: review+
Details | Diff | Review

Description neil@parkwaycc.co.uk 2011-05-29 06:16:01 PDT
There's no point calling PromiseFlatString on a known flat string.
Comment 1 neil@parkwaycc.co.uk 2011-05-29 06:17:01 PDT
Created attachment 535927 [details] [diff] [review]
Proposed patch

I also moved the call to NS_Convert... for consistency.
Comment 2 Kai Engert (:kaie) 2011-07-04 11:09:01 PDT
Comment on attachment 535927 [details] [diff] [review]
Proposed patch

thanks, r=kaie
Comment 3 neil@parkwaycc.co.uk 2011-07-04 14:09:13 PDT
Pushed changeset 320e5abc6f5a to mozilla-central.

Note You need to log in before you can comment on or make changes to this bug.