Useless use of PromiseFlatCString

RESOLVED FIXED in mozilla7

Status

()

Core
ImageLib
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.14 KB, patch
Joe Drew (not getting mail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
There's no point calling PromiseFlatCString on a known flat string.
(Assignee)

Comment 1

6 years ago
Created attachment 535931 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #535931 - Flags: review?(joe)
Comment on attachment 535931 [details] [diff] [review]
Proposed patch

Review of attachment 535931 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #535931 - Flags: review?(joe) → review+
(Assignee)

Comment 3

6 years ago
Pushed changeset cc8b37b43c5a to mozilla-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Backed out because of red on Windows desktop mobile build:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

6 years ago
Not worth my while checking things in any more, some other loser can do it.
Keywords: checkin-needed
Imported & pushed the same cset from comment 3:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/3d68f32c68b7
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.