Closed Bug 660534 Opened 12 years ago Closed 12 years ago

Useless use of PromiseFlatCString

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla7

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Proposed patch
1.14 KB, patch
joe
: review+
Details | Diff | Splinter Review 
There's no point calling PromiseFlatCString on a known flat string.
Attached patch Proposed patch — — Splinter Review 
Assignee: nobody → neil
Status: NEW → ASSIGNED

        Attachment #535931 -
        Flags: review?(joe)

    
    

    
  
Comment on attachment 535931 [details] [diff] [review]
Proposed patch

Review of attachment 535931 [details] [diff] [review]:
-----------------------------------------------------------------

        Attachment #535931 -
        Flags: review?(joe) → review+

    
    

    
  
Pushed changeset cc8b37b43c5a to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
    

    
  
Backed out because of red on Windows desktop mobile build:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
Not worth my while checking things in any more, some other loser can do it.
Keywords: checkin-needed

    
    

    
  
Imported & pushed the same cset from comment 3:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7
Keywords: checkin-needed
Whiteboard: [inbound]

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/3d68f32c68b7
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7

          You need to log in
          before you can comment on or make changes to this bug.