As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 660534 - Useless use of PromiseFlatCString
: Useless use of PromiseFlatCString
Product: Core
Classification: Components
Component: ImageLib (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla7
Assigned To:
: Milan Sreckovic [:milan]
Depends on:
  Show dependency treegraph
Reported: 2011-05-29 06:29 PDT by
Modified: 2011-06-13 20:43 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Proposed patch (1.14 KB, patch)
2011-05-29 06:30 PDT,
joe: review+
Details | Diff | Splinter Review

Description User image 2011-05-29 06:29:14 PDT
There's no point calling PromiseFlatCString on a known flat string.
Comment 1 User image 2011-05-29 06:30:10 PDT
Created attachment 535931 [details] [diff] [review]
Proposed patch
Comment 2 User image Joe Drew (not getting mail) 2011-06-09 11:21:41 PDT
Comment on attachment 535931 [details] [diff] [review]
Proposed patch

Review of attachment 535931 [details] [diff] [review]:
Comment 3 User image 2011-06-09 13:29:20 PDT
Pushed changeset cc8b37b43c5a to mozilla-central.
Comment 4 User image :Ehsan Akhgari 2011-06-09 14:04:35 PDT
Backed out because of red on Windows desktop mobile build:
Comment 5 User image 2011-06-09 14:12:31 PDT
Not worth my while checking things in any more, some other loser can do it.
Comment 6 User image Daniel Holbert [:dholbert] 2011-06-13 18:56:56 PDT
Imported & pushed the same cset from comment 3:

Note You need to log in before you can comment on or make changes to this bug.