Closed
Bug 660534
Opened 14 years ago
Closed 14 years ago
Useless use of PromiseFlatCString
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
There's no point calling PromiseFlatCString on a known flat string.
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Comment 2•14 years ago
|
||
Comment on attachment 535931 [details] [diff] [review]
Proposed patch
Review of attachment 535931 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #535931 -
Flags: review?(joe) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Pushed changeset cc8b37b43c5a to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Comment 4•14 years ago
|
||
Backed out because of red on Windows desktop mobile build:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 5•14 years ago
|
||
Not worth my while checking things in any more, some other loser can do it.
Keywords: checkin-needed
|
||
Comment 6•14 years ago
|
||
Imported & pushed the same cset from comment 3:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7
Keywords: checkin-needed
Whiteboard: [inbound]
|
|
||
Comment 7•14 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
You need to log in
before you can comment on or make changes to this bug.
Description
•