The default bug view has changed. See this FAQ.

Useless use of PromiseFlatCString

VERIFIED FIXED in mozilla7

Status

()

Core
IPC
--
trivial
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
There's no point calling PromiseFlatCString on known flat strings.
(Assignee)

Comment 1

6 years ago
Created attachment 535932 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #535932 - Flags: review?(jones.chris.g)
Attachment #535932 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

6 years ago
Pushed changeset fba5bf34ad72 to mozilla-central.
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Backed out because of red on Windows desktop mobile build:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

6 years ago
Not worth my while checking things in any more, some other loser can do it.
Keywords: checkin-needed
Imported & pushed the same cset from comment 2:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7
Keywords: checkin-needed
Whiteboard: [inbound]
(In reply to comment #5)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7
sorry, that's wrong -- copy-paste fail -- the pushed cset here is:
http://hg.mozilla.org/integration/mozilla-inbound/rev/10f50879c454
http://hg.mozilla.org/mozilla-central/rev/10f50879c454
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
Verified that file ipc/glue/GeckoChildProcessHost.cpp is updated in mozilla-central repository: "PromiseFlatCString " is not used anymore.

Is this enough to verify the bug as verified-fixed?

THank you!
(Assignee)

Comment 9

6 years ago
(In reply to Mihaela Velimiroviciu from comment #8)
> Verified that file ipc/glue/GeckoChildProcessHost.cpp is updated in
> mozilla-central repository: "PromiseFlatCString " is not used anymore.
> 
> Is this enough to verify the bug as verified-fixed?

That's about all you can do, yes.
Changing status to VERIFIED-FIXED based on comment 9
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.