Closed
Bug 660535
Opened 14 years ago
Closed 13 years ago
Useless use of PromiseFlatCString
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
VERIFIED
FIXED
mozilla7
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
cjones
:
review+
|
Details | Diff | Splinter Review |
There's no point calling PromiseFlatCString on known flat strings.
|
Assignee | |
Comment 1•14 years ago
|
||
|
||
Updated•14 years ago
|
Attachment #535932 -
Flags: review?(jones.chris.g) → review+
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 3•13 years ago
|
||
Backed out because of red on Windows desktop mobile build: http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Comment 4•13 years ago
|
||
Not worth my while checking things in any more, some other loser can do it.
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
Imported & pushed the same cset from comment 2: http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7
Keywords: checkin-needed
Whiteboard: [inbound]
|
|
||
Comment 6•13 years ago
|
||
(In reply to comment #5) > http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7 sorry, that's wrong -- copy-paste fail -- the pushed cset here is: http://hg.mozilla.org/integration/mozilla-inbound/rev/10f50879c454
|
|
||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/10f50879c454
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
|
||
Comment 8•13 years ago
|
||
Verified that file ipc/glue/GeckoChildProcessHost.cpp is updated in mozilla-central repository: "PromiseFlatCString " is not used anymore. Is this enough to verify the bug as verified-fixed? THank you!
|
|
Assignee | |
Comment 9•13 years ago
|
||
(In reply to Mihaela Velimiroviciu from comment #8) > Verified that file ipc/glue/GeckoChildProcessHost.cpp is updated in > mozilla-central repository: "PromiseFlatCString " is not used anymore. > > Is this enough to verify the bug as verified-fixed? That's about all you can do, yes.
|
|
||
Comment 10•13 years ago
|
||
Changing status to VERIFIED-FIXED based on comment 9
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•