660535 - Useless use of PromiseFlatCString

Status: VERIFIED FIXED

(Core :: IPC, defect)

Description

[[e-mail]]

There's no point calling PromiseFlatCString on known flat strings.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[[e-mail]]

Pushed changeset fba5bf34ad72 to mozilla-central.

Comment 3

[(no longer active)]

Backed out because of red on Windows desktop mobile build:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz

Comment 4

[[e-mail]]

Not worth my while checking things in any more, some other loser can do it.

Comment 5

[Daniel Holbert [:dholbert]]

Imported & pushed the same cset from comment 2:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7

Comment 6

[Daniel Holbert [:dholbert]]

(In reply to comment #5)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/3d68f32c68b7
sorry, that's wrong -- copy-paste fail -- the pushed cset here is:
http://hg.mozilla.org/integration/mozilla-inbound/rev/10f50879c454

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/10f50879c454

Comment 8

[Mihaela Velimiroviciu (:mihaelav)]

Verified that file ipc/glue/GeckoChildProcessHost.cpp is updated in mozilla-central repository: "PromiseFlatCString " is not used anymore.

Is this enough to verify the bug as verified-fixed?

THank you!

Comment 9

[[e-mail]]

(In reply to Mihaela Velimiroviciu from comment #8)
> Verified that file ipc/glue/GeckoChildProcessHost.cpp is updated in
> mozilla-central repository: "PromiseFlatCString " is not used anymore.
> 
> Is this enough to verify the bug as verified-fixed?

That's about all you can do, yes.

Comment 10

[Mihaela Velimiroviciu (:mihaelav)]

Changing status to VERIFIED-FIXED based on comment 9