Closed Bug 660535 Opened 8 years ago Closed 8 years ago

Useless use of PromiseFlatCString

Categories

(Core :: IPC, defect, trivial)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED
mozilla7

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

There's no point calling PromiseFlatCString on known flat strings.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #535932 - Flags: review?(jones.chris.g)
Attachment #535932 - Flags: review?(jones.chris.g) → review+
Pushed changeset fba5bf34ad72 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Backed out because of red on Windows desktop mobile build:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Not worth my while checking things in any more, some other loser can do it.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/10f50879c454
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
Verified that file ipc/glue/GeckoChildProcessHost.cpp is updated in mozilla-central repository: "PromiseFlatCString " is not used anymore.

Is this enough to verify the bug as verified-fixed?

THank you!
(In reply to Mihaela Velimiroviciu from comment #8)
> Verified that file ipc/glue/GeckoChildProcessHost.cpp is updated in
> mozilla-central repository: "PromiseFlatCString " is not used anymore.
> 
> Is this enough to verify the bug as verified-fixed?

That's about all you can do, yes.
Changing status to VERIFIED-FIXED based on comment 9
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.