The default bug view has changed. See this FAQ.

Useless uses of PromiseFlat(C)String

RESOLVED FIXED in mozilla7

Status

()

Core
DOM
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
There's no point calling PromiseFlat(C)String on known flat strings.
(Assignee)

Comment 1

6 years ago
Created attachment 535933 [details] [diff] [review]
Proposed patch
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #535933 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Attachment #535933 - Flags: review?(Olli.Pettay) → review+
(Assignee)

Comment 2

6 years ago
Pushed changeset b9dab5588ce1 to mozilla-central.
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Backed out because of red on Windows desktop mobile build:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

6 years ago
Not worth my while checking things in any more, some other loser can do it.
Keywords: checkin-needed
(Assignee)

Comment 5

6 years ago
Created attachment 538376 [details] [diff] [review]
Updated for bitrot

Bug 660721 divergently renamed nsObjectFrame.cpp to nsPluginInstanceOwner.cpp
Attachment #538376 - Flags: review+
(In reply to comment #5)
> Bug 660721 divergently renamed nsObjectFrame.cpp to nsPluginInstanceOwner.cpp

That means it made a copy of that file, I think.

It looks like you just changed your patch with s/nsObjectFrame.cpp/nsPluginInstanceOwner.cpp/, but presumably you *also* want to patch the original file (nsObjectFrame.cpp), right?
(In reply to comment #6)
> It looks like you just changed your patch with
> s/nsObjectFrame.cpp/nsPluginInstanceOwner.cpp/, but presumably you *also*
> want to patch the original file (nsObjectFrame.cpp), right?

Ah, nevermind - while nsObjectFrame.cpp still exists, it no longer has the relevant chunk of code. (Bug 660721 deleted that chunk, along with creating the copy.)
http://hg.mozilla.org/integration/mozilla-inbound/rev/f68c52f253e7
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/f68c52f253e7
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.