Closed Bug 660536 Opened 9 years ago Closed 9 years ago

Useless uses of PromiseFlat(C)String

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(2 files)

There's no point calling PromiseFlat(C)String on known flat strings.
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #535933 - Flags: review?(Olli.Pettay)
Attachment #535933 - Flags: review?(Olli.Pettay) → review+
Pushed changeset b9dab5588ce1 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Backed out because of red on Windows desktop mobile build:

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307650903.1307652099.19955.gz
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Not worth my while checking things in any more, some other loser can do it.
Keywords: checkin-needed
Bug 660721 divergently renamed nsObjectFrame.cpp to nsPluginInstanceOwner.cpp
Attachment #538376 - Flags: review+
(In reply to comment #5)
> Bug 660721 divergently renamed nsObjectFrame.cpp to nsPluginInstanceOwner.cpp

That means it made a copy of that file, I think.

It looks like you just changed your patch with s/nsObjectFrame.cpp/nsPluginInstanceOwner.cpp/, but presumably you *also* want to patch the original file (nsObjectFrame.cpp), right?
(In reply to comment #6)
> It looks like you just changed your patch with
> s/nsObjectFrame.cpp/nsPluginInstanceOwner.cpp/, but presumably you *also*
> want to patch the original file (nsObjectFrame.cpp), right?

Ah, nevermind - while nsObjectFrame.cpp still exists, it no longer has the relevant chunk of code. (Bug 660721 deleted that chunk, along with creating the copy.)
http://hg.mozilla.org/mozilla-central/rev/f68c52f253e7
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.