Closed
Bug 660638
Opened 14 years ago
Closed 14 years ago
OOM in Compiler::compileScript when |script| is not checked
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: paul.biggar, Assigned: paul.biggar)
References
Details
(Whiteboard: [fixed-in-tracemonkey])
Attachments
(1 file)
1.27 KB,
patch
|
Waldo
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In Compiler::compileScript, |script| can be NULL when passed to defineGlobals. This returns NULL instead.
Attachment #536086 -
Flags: review?(jwalden+bmo)
Updated•14 years ago
|
Attachment #536086 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 1•14 years ago
|
||
Whiteboard: [fixed-in-tracemonkey]
Assignee | ||
Comment 2•14 years ago
|
||
Comment 4•14 years ago
|
||
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/29b7c7a14506
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 5•14 years ago
|
||
This affects 2.0.0, beta and aurora. Paul, is this low enough risk to make it into Firefox 6?
Assignee | ||
Comment 6•14 years ago
|
||
Sure, this is pretty low-risk.
Updated•14 years ago
|
Comment 7•14 years ago
|
||
Comment on attachment 536086 [details] [diff] [review]
fix OOM
Approved for Aurora landing. (not tracking, though). Please land as soon as possible since Aurora only has a couple of weeks left.
Attachment #536086 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 8•14 years ago
|
||
Just to clarify, who is going to land this in aurora? Is it me? I'm OK with that, I just want to be sure :)
Comment 9•14 years ago
|
||
(In reply to comment #8)
> Just to clarify, who is going to land this in aurora? Is it me?
Yes.
Assignee: general → pbiggar
Assignee | ||
Comment 10•14 years ago
|
||
Landed in aurora:
http://hg.mozilla.org/releases/mozilla-aurora/rev/f69cd8f15cdf
Assignee | ||
Updated•14 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•