Closed Bug 660638 Opened 13 years ago Closed 13 years ago

OOM in Compiler::compileScript when |script| is not checked

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox6 - fixed

People

(Reporter: paul.biggar, Assigned: paul.biggar)

References

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 file)

fix OOM
1.27 KB, patch
Waldo
: review+
asa
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached patch fix OOM — — Splinter Review 
In Compiler::compileScript, |script| can be NULL when passed to defineGlobals. This returns NULL instead.
Attachment #536086 - Flags: review?(jwalden+bmo)
Attachment #536086 - Flags: review?(jwalden+bmo) → review+
https://bugzilla.mozilla.org/show_bug.cgi?id=660638
Whiteboard: [fixed-in-tracemonkey]
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
This affects 2.0.0, beta and aurora. Paul, is this low enough risk to make it into Firefox 6?
status-firefox6: --- → affected
tracking-firefox6: --- → ?
OS: Mac OS X → All
Sure, this is pretty low-risk.
Comment on attachment 536086 [details] [diff] [review]
fix OOM

Approved for Aurora landing. (not tracking, though). Please land as soon as possible since Aurora only has a couple of weeks left.
Attachment #536086 - Flags: approval-mozilla-aurora+
Just to clarify, who is going to land this in aurora? Is it me? I'm OK with that, I just want to be sure :)
(In reply to comment #8)
> Just to clarify, who is going to land this in aurora? Is it me? 

Yes.
Assignee: general → pbiggar
status-firefox6: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: