OOM in Compiler::compileScript when |script| is not checked

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: paul.biggar, Assigned: paul.biggar)

Tracking

unspecified
x86
All
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox6- fixed)

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 attachment)

Assignee

Description

8 years ago
Posted patch fix OOMSplinter Review
In Compiler::compileScript, |script| can be NULL when passed to defineGlobals. This returns NULL instead.
Attachment #536086 - Flags: review?(jwalden+bmo)
Attachment #536086 - Flags: review?(jwalden+bmo) → review+
Assignee

Comment 1

8 years ago
https://bugzilla.mozilla.org/show_bug.cgi?id=660638
Whiteboard: [fixed-in-tracemonkey]
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 5

8 years ago
This affects 2.0.0, beta and aurora. Paul, is this low enough risk to make it into Firefox 6?
OS: Mac OS X → All
Assignee

Comment 6

8 years ago
Sure, this is pretty low-risk.
Comment on attachment 536086 [details] [diff] [review]
fix OOM

Approved for Aurora landing. (not tracking, though). Please land as soon as possible since Aurora only has a couple of weeks left.
Attachment #536086 - Flags: approval-mozilla-aurora+
Assignee

Comment 8

8 years ago
Just to clarify, who is going to land this in aurora? Is it me? I'm OK with that, I just want to be sure :)
(In reply to comment #8)
> Just to clarify, who is going to land this in aurora? Is it me? 

Yes.
Assignee: general → pbiggar
Assignee

Updated

8 years ago
You need to log in before you can comment on or make changes to this bug.