Closed
Bug 660662
Opened 13 years ago
Closed 13 years ago
Eliminate NS_(ceil|floor)
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(2 files)
|
37.42 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
997 bytes,
patch
|
bent.mozilla
:
review+
|
Details | Diff | Splinter Review |
I don't see any reason for having these guys around.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #536122 -
Flags: review?(roc)
Comment on attachment 536122 [details] [diff] [review] Remove NS_(floor|ceil) Review of attachment 536122 [details] [diff] [review]: -----------------------------------------------------------------
Attachment #536122 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
MSVC wasn't building the patch because we were flooring an int. This patch gets rid of that.
Attachment #536959 -
Flags: review?(bent.mozilla)
|
||
Updated•13 years ago
|
Attachment #536959 -
Flags: review?(bent.mozilla) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/188621c4b912
|
||
Comment 5•13 years ago
|
||
attachment 536959 [details] [diff] [review] in mozilla-central for Firefox 7: http://hg.mozilla.org/mozilla-central/rev/188621c4b912 Not resolving the bug because attachment 536122 [details] [diff] [review] has not yet landed. You can resolve this bug when that patch lands (or if it's no longer needed).
Assignee: nobody → jmuizelaar
Target Milestone: --- → mozilla7
http://hg.mozilla.org/mozilla-central/rev/6fd7a1b9ef64
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: mozilla7 → mozilla8
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•