Make element.dir a real enumerated attribute

VERIFIED FIXED in mozilla7

Status

()

Core
DOM: Core & HTML
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

({dev-doc-complete})

Trunk
mozilla7
dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 536107 [details] [diff] [review]
Patch v1

It currently hand-rolls similar code.
Attachment #536107 - Flags: review?(bzbarsky)
Comment on attachment 536107 [details] [diff] [review]
Patch v1

r=me
Attachment #536107 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/f96c523a2178
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: dev-doc-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
I'm not sure what needs documenting here; this looks like it's a strictly internal tweak that doesn't really affect anyone. What am I missing?
Documentation updated after talking to Ms2ger for a bit in IRC:

https://developer.mozilla.org/en/DOM/element.dir

Also mentioned on Firefox 7 for developers.
Keywords: dev-doc-needed → dev-doc-complete

Comment 5

6 years ago
content/html/content/test/test_bug660663.html passed on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
+ Aurora (Fx 8.0a2) & Nightly (Fx 9.0a1).

Test Results:
Passed: 31
Failed: 0
Todo: 4
todo | auto should be accepted as a valid value for dir - got "", expected "auto"
todo | Enumerated attributes should be case-insensitive. - got "", expected "auto"
todo | auto should be accepted as a valid value for dir - got "", expected "auto"
todo | Enumerated attributes should be case-insensitive. - got "", expected "auto"
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.