660663 - Make element.dir a real enumerated attribute

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

It currently hand-rolls similar code.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 536107 [details] [diff] [review]
Patch v1

r=me

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/f96c523a2178

Comment 3

[Eric Shepherd [:sheppy]]

I'm not sure what needs documenting here; this looks like it's a strictly internal tweak that doesn't really affect anyone. What am I missing?

Comment 4

[Eric Shepherd [:sheppy]]

Documentation updated after talking to Ms2ger for a bit in IRC:

https://developer.mozilla.org/en/DOM/element.dir

Also mentioned on Firefox 7 for developers.

Comment 5

[Ioana (away)]

content/html/content/test/test_bug660663.html passed on:
Mozilla/5.0 (Windows NT 6.1; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (X11; Linux i686; rv:7.0) Gecko/20100101 Firefox/7.0
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0
+ Aurora (Fx 8.0a2) & Nightly (Fx 9.0a1).

Test Results:
Passed: 31
Failed: 0
Todo: 4
todo | auto should be accepted as a valid value for dir - got "", expected "auto"
todo | Enumerated attributes should be case-insensitive. - got "", expected "auto"
todo | auto should be accepted as a valid value for dir - got "", expected "auto"
todo | Enumerated attributes should be case-insensitive. - got "", expected "auto"