Closed
Bug 660665
Opened 14 years ago
Closed 14 years ago
Use existing string bundle rather than creating a new one for MsgOpenFromFile
Categories
(SeaMonkey :: MailNews: Message Display, defect)
SeaMonkey
MailNews: Message Display
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.4
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
mailWindowOverlay.xul already creates a string bundle so mailWindowOverlay.js should not need to create its own for MsgOpenFromFile dialog.
This patch:
* Makes use of gMessengerBundle global and removes use of string bundle service.
Attachment #536111 -
Flags: review?(neil)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 536111 [details] [diff] [review]
Use gMessengerBundle patch [Checked in: Comment 2]
>+ if (!gMessengerBundle)
>+ gMessengerBundle = document.getElementById("bundle_messenger");
Don't bother with this, it gets set in CreateMailWindowGlobals. (I've no idea why some sites null-check.)
Attachment #536111 -
Flags: review?(neil) → review+
Comment on attachment 536111 [details] [diff] [review]
Use gMessengerBundle patch [Checked in: Comment 2]
http://hg.mozilla.org/comm-central/rev/c2a14a487c41
without null check and setting of gMessengerBundle
Attachment #536111 -
Attachment description: Use gMessengerBundle patch → Use gMessengerBundle patch [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [SM24]
Target Milestone: --- → Future
You need to log in
before you can comment on or make changes to this bug.
Description
•