Last Comment Bug 660668 - Assertion failure: !start->hasTable(), at ../../jsscope.h:751 after OOM
: Assertion failure: !start->hasTable(), at ../../jsscope.h:751 after OOM
Status: RESOLVED FIXED
[fixed-in-tracemonkey]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: general
:
Mentors:
Depends on:
Blocks: 624094
  Show dependency treegraph
 
Reported: 2011-05-30 09:55 PDT by Paul Biggar
Modified: 2011-06-21 16:31 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (916 bytes, patch)
2011-05-30 09:55 PDT, Paul Biggar
n.nethercote: review+
Details | Diff | Review

Description Paul Biggar 2011-05-30 09:55:24 PDT
Created attachment 536117 [details] [diff] [review]
fix

Shape::hashify can call setTable even on OOM (when getTable()->init() fails). However, Shape::search() assumes that hasTable() will be false on OOM. This makes search()'s assumption true.
Comment 1 Nicholas Nethercote [:njn] 2011-05-30 17:40:57 PDT
Comment on attachment 536117 [details] [diff] [review]
fix

Review of attachment 536117 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 3 Paul Biggar 2011-06-21 16:31:35 PDT
cdleary-bot missed this.

Note You need to log in before you can comment on or make changes to this bug.