Closed
Bug 660681
Opened 14 years ago
Closed 13 years ago
LeaveFunction doesn't check outer_ale enough for OOM
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: paul.biggar, Assigned: paul.biggar)
References
Details
(Whiteboard: [fixed-in-tracemonkey])
Attachments
(1 file, 1 obsolete file)
|
1.31 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
In LeaveFunction, outer_ale is checked a number of times, but the last one is not checked for OOM. Simple fix.
Attachment #536135 -
Flags: review?(jimb)
|
||
Updated•14 years ago
|
Summary: LeaveFunction doesn't check outer_ole enough for OOM → LeaveFunction doesn't check outer_ale enough for OOM
|
|
||
Comment 1•14 years ago
|
||
Comment on attachment 536135 [details] [diff] [review]
fix
Review of attachment 536135 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsparse.cpp
@@ +2839,5 @@
> */
> outer_ale = MakePlaceholder(dn, tc);
> }
>
> + if (!outer_ale)
Shouldn't this be just after the call to MakePlaceHolder? These checks should go right after the call that could fail.
|
Assignee | |
Comment 2•14 years ago
|
||
Assignee: general → pbiggar
Attachment #536135 -
Attachment is obsolete: true
Attachment #536135 -
Flags: review?(jimb)
Attachment #537582 -
Flags: review?(jimb)
|
|
||
Updated•14 years ago
|
Attachment #537582 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: [fixed-in-tracemonkey]
|
||
Comment 4•13 years ago
|
||
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/cc612a118e7c
|
|
||
Updated•13 years ago
|
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•