Closed Bug 660681 Opened 12 years ago Closed 12 years ago

LeaveFunction doesn't check outer_ale enough for OOM

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: paul.biggar, Assigned: paul.biggar)

References

Details

(Whiteboard: [fixed-in-tracemonkey])

Attachments

(1 file, 1 obsolete file)

move the check
1.31 KB, patch
jimb
: review+
Details | Diff | Splinter Review
Attached patch fix (obsolete) — — Splinter Review 
In LeaveFunction, outer_ale is checked a number of times, but the last one is not checked for OOM. Simple fix.
Attachment #536135 - Flags: review?(jimb)
Summary: LeaveFunction doesn't check outer_ole enough for OOM → LeaveFunction doesn't check outer_ale enough for OOM
Comment on attachment 536135 [details] [diff] [review]
fix

Review of attachment 536135 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsparse.cpp
@@ +2839,5 @@
>                   */
>                  outer_ale = MakePlaceholder(dn, tc);
>              }
>  
> +            if (!outer_ale)

Shouldn't this be just after the call to MakePlaceHolder? These checks should go right after the call that could fail.
Attached patch move the check — — Splinter Review 
Assignee: general → pbiggar

        Attachment #536135 -
        Attachment is obsolete: true

        Attachment #536135 -
        Flags: review?(jimb)

        Attachment #537582 -
        Flags: review?(jimb)

    
  

        Attachment #537582 -
        Flags: review?(jimb) → review+

    
    

    
  
http://hg.mozilla.org/tracemonkey/rev/cc612a118e7c
Whiteboard: [fixed-in-tracemonkey]
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.