Closed Bug 660718 Opened 8 years ago Closed 8 years ago

Add link from about:support to about:memory

Categories

(Toolkit :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: jruderman, Assigned: emorley)

Details

Attachments

(2 files)

Maybe just a simple line in the first table, near the link to about:plugins:

Memory use      about:memory
OS: Mac OS X → All
Hardware: x86 → All
Attached patch Patch v1Splinter Review
Adds "Memory Use     about:memory" as an extra row to the end of the 'Application Basics' block in about:support, after the about:crashes entry.

I'm open to suggestions as to the placement/naming.

My reasons for adding to the end of the application basics block were:
- Avoids breaking muscle memory for the other entries above it
- The addition will hopefully be more noticeable for people who are used to about:support already, who may otherwise miss it if added halfway through the existing list
- about:plugins and about:buildconfig are related to the current install rather than the current session, so it seems to make more sense to put about:memory with about:crashes (which is at least about recent sessions, even if not the current one)

Also removes some trailing whitespace in aboutSupport.xhtml.
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #559985 - Flags: review?(gavin.sharp)
Flags: in-testsuite-
Attached image Screenshot v1
Quick sanity check, seeing as I was pushing a bunch of things to try anyway:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=39b4ffb18fd5
Comment on attachment 559985 [details] [diff] [review]
Patch v1

I'm going to break the rules, and r+ this!
Attachment #559985 - Flags: review?(gavin.sharp) → review+
Product: Firefox → Toolkit
QA Contact: general → general
Thanks Ehsan :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d0c5f3e3392
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/9d0c5f3e3392
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.