Closed Bug 660739 Opened 14 years ago Closed 14 years ago

ERROR TEST-UNEXPECTED-FAIL test_idcheck.xul | check id: messengercompose.xul#contentAreaContextSet

Categories

(SeaMonkey :: MailNews: Composition, defect)

Product:
SeaMonkey
Component:
MailNews: Composition
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.2 wontfix, seamonkey2.3 wontfix, seamonkey2.4 wontfix, seamonkey2.5 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.5
Tracking Flags:
Tracking Status
seamonkey2.2 --- wontfix
seamonkey2.3 --- wontfix
seamonkey2.4 --- wontfix
seamonkey2.5 --- fixed

People

(Reporter: philip.chee, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Remove popupset [Checked in: Comment 6]
950 bytes, patch
neil
: review+
Details | Diff | Splinter Review
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1306807420.1306810850.22456.gz 10451 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/suite/common/tests/chrome/test_idcheck.xul | check id: messengercompose.xul#contentAreaContextSet Ian, you forgot to fix the test ;-)
No. I didn't forget, the test is correct. I just have to wait for the patch to land from bug 657161, then I can remove the popupset line from sidebarOverlay.xul (which I did forget to include in that patch), so I'll put the patch on here.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Depends on: 657161
Attached patch Remove popupset (obsolete) — — Splinter Review
Once all windows that use the sidebar overlay have the contentAreaContextSet popupset the overlay won't need it - test will then pass again.
Attachment #536496 - Flags: review?(neil)
Comment on attachment 536496 [details] [diff] [review] Remove popupset Wrong patch?
Correct patch this time
Attachment #536496 - Attachment is obsolete: true
Attachment #536496 - Flags: review?(neil)
Attachment #536690 - Flags: review?(neil)
Comment on attachment 536690 [details] [diff] [review] Remove popupset [Checked in: Comment 6] This could do with a comment somewhere mentioning the dependency.
Attachment #536690 - Flags: review?(neil) → review+
Comment on attachment 536690 [details] [diff] [review] Remove popupset [Checked in: Comment 6] With additional comment: http://hg.mozilla.org/comm-central/rev/3435704c16d9
Attachment #536690 - Attachment description: Remove popupset → Remove popupset [Checked in: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
status-seamonkey2.2: --- → wontfix
status-seamonkey2.3: --- → wontfix
status-seamonkey2.4: --- → wontfix
status-seamonkey2.5: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: