Last Comment Bug 660765 - GCLI Requisition._onAssignmentChange could be simplified
: GCLI Requisition._onAssignmentChange could be simplified
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: P3 normal (vote)
: Firefox 17
Assigned To: Joe Walker [:jwalker] (needinfo me or ping on irc)
:
Mentors:
Depends on: 773565
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-31 01:40 PDT by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-08-27 05:13 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-05-31 01:40:37 PDT
It's possible that Requisition._onAssignmentChange could be simplified by having each Argument be aware of the input array/index that it belongs to - that way we could say to the Argument - adjust yourself, and we wouldn't need to do the search/alter operation that we do in _onAssignmentChange.

To be aware of:

- Some of the objects in the system are sort of 'final' in that we try not to change them post-creation. We should check this before we plough on

- Arguments are used in 2 ways which might need tweaking - We _tokenize() the typed input into 'RawArgument's, and then _assign() these arguments to Assignments, which sometimes involves creation of higher-order Arguments like TrueNamedArgument and ArrayArgument which remember the Argument(s) from which they were created. HOWEVER we don't always go for higher-order Arguments. Perhaps we should formalize the distinction between the original Arguments from _tokenize() (Maybe called RawArgument) and the types of argument that we put into Assignments.
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2011-11-18 09:59:45 PST
Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.
Comment 2 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-01-13 09:42:37 PST
Triage. Filter on PEGASUS.
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-07-31 06:28:52 PDT
This bug should be solved automatically by bug 773565.
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-08-27 05:13:38 PDT
Triage

Note You need to log in before you can comment on or make changes to this bug.