GCLI Requisition._onAssignmentChange could be simplified

RESOLVED FIXED in Firefox 17

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jwalker, Assigned: jwalker)

Tracking

Trunk
Firefox 17
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

It's possible that Requisition._onAssignmentChange could be simplified by having each Argument be aware of the input array/index that it belongs to - that way we could say to the Argument - adjust yourself, and we wouldn't need to do the search/alter operation that we do in _onAssignmentChange.

To be aware of:

- Some of the objects in the system are sort of 'final' in that we try not to change them post-creation. We should check this before we plough on

- Arguments are used in 2 ways which might need tweaking - We _tokenize() the typed input into 'RawArgument's, and then _assign() these arguments to Assignments, which sometimes involves creation of higher-order Arguments like TrueNamedArgument and ArrayArgument which remember the Argument(s) from which they were created. HOWEVER we don't always go for higher-order Arguments. Perhaps we should formalize the distinction between the original Arguments from _tokenize() (Maybe called RawArgument) and the types of argument that we put into Assignments.
Blocks: 659052
Moving GCLI bugs to Developer Tools: Console. Filter on 'baked beans are off'.
Component: Developer Tools → Developer Tools: Console
Triage. Filter on PEGASUS.
Priority: -- → P3
No longer blocks: 659052
This bug should be solved automatically by bug 773565.
Assignee: nobody → jwalker
Status: NEW → ASSIGNED
Depends on: 773565
Target Milestone: --- → Firefox 17
Triage
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.