Closed
Bug 660789
Opened 14 years ago
Closed 14 years ago
Mozmill test for checking the SRC attribute while installing an add-on from the 'Up &Coming' module
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: AlexLakatos, Assigned: AlexLakatos)
Details
(Whiteboard: [mozmill-restart][aom-discovery] )
Attachments
(1 file, 1 obsolete file)
3.72 KB,
patch
|
Details | Diff | Splinter Review |
Tracking bug to develop a Mozmill test for the following Litmus test:
Check the SRC attribute while installing an add-on from the 'Up &Coming' module
https://litmus.mozilla.org/show_test.cgi?id=15374
Updated•14 years ago
|
Whiteboard: [aom-discovery]
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13998215
Assignee | ||
Comment 2•14 years ago
|
||
Assignee | ||
Comment 3•14 years ago
|
||
just wanting some feedback before i submit it for r?
Attachment #536582 -
Attachment is obsolete: true
Attachment #536583 -
Flags: feedback?(anthony.s.hughes)
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → alex.lakatos
Status: NEW → ASSIGNED
Comment 4•14 years ago
|
||
Comment on attachment 536583 [details] [diff] [review]
patch v1.0
Just some drive-by comments before I'm away the next couple of days...
>+ //Click on a random addon
>+ var addonList = discovery.getElements({type: "upAndComing_addons", parent: upComing});
>+ var randomNumber = Math.floor(Math.random()*addonList.length);
>+ var randomAddon = addonList[randomNumber];
There is no need to use an extra variable for the random number. Also separate operands and operators by a space.
>+ var isSrcPresent = (addToFirefox.getNode()["href"].indexOf("src=discovery-upandcoming") != -1);
Please use the dot notation to retrieve the href which is .getNode().href.
Comment on attachment 536583 [details] [diff] [review]
patch v1.0
I wonder if we even need this test separately. Can this not be integrated into the Up&Coming test? It seems like it's just an additional spotcheck.
Attachment #536583 -
Flags: feedback?(anthony.s.hughes) → feedback?(hskupin)
Updated•14 years ago
|
Attachment #536583 -
Flags: feedback?(hskupin)
Comment 6•14 years ago
|
||
As talked in the automation meeting it looks to me that this test can or even is completely covered by Selenium. Dave, can you help out?
Alex, Anthony will send you guys an email shortly for our proposed changes in handling the test creation. It should make it way easier for you in the future.
I'm thinking we can probably be added as an assert to the Up & Coming Add-on Install test in bug 657497.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Whiteboard: [mozmill-remote][aom-discovery] → [mozmill-restart][aom-discovery]
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•