660898 - Add-ons in the application distribution directory should be ignored when extensions.enabledScopes doesn't include the application

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Dave Townsend [:mossop]]

Because these get installed to the profile they currently work even when extensions.enabledScopes doesn't include the application. We should not install them in that case (though we'd still load ones that had previously been installed).

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This bug blocks our Mozmill update tests for major releases since the feedback extension is installed. See also bug 627595. I will raise the severity to major because it really impacts the way when we can sign-off from update tests. Right now, all of those updates have to be run manually. It would be great if we can get it fixed asap. Thanks.

Comment 2

[Benjamin Smedberg]

Which set are we talking about? The ones in appdir/distribution/bundles, or the ones in appdir/distribution?

Comment 3

[Dave Townsend [:mossop]]

The ones in appdir/distribution/extensions

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

With the workaround Dave mentioned over on bug 627595 we were able to fix for the Mozmill case. So we aren't blocked on it anymore.

Comment 5

[Mike Kaply [:mkaply]]

Mossop: Do you still agree with this statement?

Extensions in the distribution/extensions directory should not get installed if extensions.enabledScopes doesn't include the profile.

If so, I'll take this as a bug against distributions.

Comment 6

[Dave Townsend [:mossop]]

(In reply to Mike Kaply [:mkaply] from comment #5)
> Mossop: Do you still agree with this statement?
> 
> Extensions in the distribution/extensions directory should not get installed
> if extensions.enabledScopes doesn't include the profile.

It makes sense to me but I can't think of any cases beyond the testing issue we filed this for so I don't think it's a high priority unless you have other use cases I'm not thinking of.

Comment 7

[Shane Caraveo (:mixedpuppy)]

Since this appears to be a test issue only, and extensions.installDistroAddons (pref'd off everywhere other than desktop) can be set to false and there has been no other affect from this in over 3 years, I'm inclined to wontfix this.

The only alternative I think that might make sense is to make a DistributionLocation class like we have for builtins and avoid installing these into the profile. Then we could add a SCOPE_DISTRIBUTION. I'm not sure this is worth the effort.