660942 - Account Copies & Folders page uses h as accesskey which will conflict with help button

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Ian Neal]

Attachment: Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

At the moment, in copies & folders account settings pane, the accesskey for archive "Other:" is set to h which conflicts with the accesskey for the help button.

This patch:
* Changes "Other:" to "Other Folder:" for all four sections.
* Changes accesskey for Archive to "v".
* Changes accesskey for Archive's other folder to "F".

Comment 1

[Ian Neal]

Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

http://hg.mozilla.org/comm-central/rev/c163d201bbbb

Comment 2

[Ian Neal]

Should be SM2.4

Comment 3

[[e-mail]]

Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

> <!ENTITY archiveHierarchyButton.label "Archive optionsâ¦">
> <!ENTITY archiveHierarchyButton.accesskey "A">
I didn't notice this before... any chance we can change it to "n"?

Comment 4

[Ian Neal]

Attachment: Fix all accesskey conflicts this time [Checkin: Comment 5, aurora/beta Comment 8]

This patch (as suggested by Neil):
* Moves "automatically" onto "Place a copy in:" label so that "u" is available as an accesskey.
* Changes accesskey for "Places replies" to "P".
* Changes accesskey for "Archive options..." to "n".
* Changes accesskey for Archive's "Other folder" to "l".

Comment 5

[Ian Neal]

Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

Need both patches for comm-aurora and comm-central, locales will hopefully not have the accesskey conflicts anyway

Comment 6

[Ian Neal]

Comment on attachment 537146 [details] [diff] [review]
Fix all accesskey conflicts this time [Checkin: Comment 5, aurora/beta Comment 8]

Need both patches for comm-aurora and comm-central, locales will hopefully not have the accesskey conflicts anyway

Comment 7

[Robert Kaiser]

Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

This is really walking the line of needing a string key change, but let's accept it this way.

Comment 8

[Ian Neal]

Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

http://hg.mozilla.org/releases/comm-aurora/rev/6df12c4bc8be
http://hg.mozilla.org/releases/comm-beta/rev/20b1e25ed4ae