Account Copies & Folders page uses h as accesskey which will conflict with help button

RESOLVED FIXED in seamonkey2.4

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: iann_bugzilla, Assigned: iann_bugzilla)

Tracking

Trunk
seamonkey2.4
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.2 fixed, seamonkey2.3 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

8 years ago
At the moment, in copies & folders account settings pane, the accesskey for archive "Other:" is set to h which conflicts with the accesskey for the help button.

This patch:
* Changes "Other:" to "Other Folder:" for all four sections.
* Changes accesskey for Archive to "v".
* Changes accesskey for Archive's other folder to "F".
Attachment #536384 - Flags: review?(neil)
Attachment #536384 - Flags: review?(neil) → review+
Assignee

Comment 1

8 years ago
Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

http://hg.mozilla.org/comm-central/rev/c163d201bbbb
Attachment #536384 - Attachment description: Fix accesskey patch → Fix accesskey patch [Checked in: comment 1]
Assignee

Comment 2

8 years ago
Should be SM2.4
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [SM24]
Target Milestone: --- → Future
Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

> <!ENTITY archiveHierarchyButton.label "Archive options…">
> <!ENTITY archiveHierarchyButton.accesskey "A">
I didn't notice this before... any chance we can change it to "n"?
Assignee

Updated

8 years ago
Whiteboard: [SM24]
Target Milestone: Future → seamonkey2.4
Assignee

Updated

8 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 4

8 years ago
This patch (as suggested by Neil):
* Moves "automatically" onto "Place a copy in:" label so that "u" is available as an accesskey.
* Changes accesskey for "Places replies" to "P".
* Changes accesskey for "Archive options..." to "n".
* Changes accesskey for Archive's "Other folder" to "l".
Attachment #537146 - Flags: review?(neil)
Attachment #537146 - Flags: review?(neil) → review+
Assignee

Updated

8 years ago
Attachment #537146 - Attachment description: Fix all accesskey conflicts this time → Fix all accesskey conflicts this time [Checkin: Comment 5]
Assignee

Updated

8 years ago
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Assignee

Comment 5

8 years ago
Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

Need both patches for comm-aurora and comm-central, locales will hopefully not have the accesskey conflicts anyway
Attachment #536384 - Flags: approval-comm-beta?
Attachment #536384 - Flags: approval-comm-aurora?
Assignee

Comment 6

8 years ago
Comment on attachment 537146 [details] [diff] [review]
Fix all accesskey conflicts this time [Checkin: Comment 5, aurora/beta Comment 8]

Need both patches for comm-aurora and comm-central, locales will hopefully not have the accesskey conflicts anyway
Attachment #537146 - Flags: approval-comm-beta?
Attachment #537146 - Flags: approval-comm-aurora?

Comment 7

8 years ago
Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

This is really walking the line of needing a string key change, but let's accept it this way.
Attachment #536384 - Flags: approval-comm-beta?
Attachment #536384 - Flags: approval-comm-beta+
Attachment #536384 - Flags: approval-comm-aurora?
Attachment #536384 - Flags: approval-comm-aurora+

Updated

8 years ago
Attachment #537146 - Flags: approval-comm-beta?
Attachment #537146 - Flags: approval-comm-beta+
Attachment #537146 - Flags: approval-comm-aurora?
Attachment #537146 - Flags: approval-comm-aurora+
Assignee

Comment 8

8 years ago
Comment on attachment 536384 [details] [diff] [review]
Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]

http://hg.mozilla.org/releases/comm-aurora/rev/6df12c4bc8be
http://hg.mozilla.org/releases/comm-beta/rev/20b1e25ed4ae
Attachment #536384 - Attachment description: Fix accesskey patch [Checked in: comment 1] → Fix accesskey patch [Checked in: comment 1, aurora/beta comment 8]
Assignee

Updated

8 years ago
Attachment #537146 - Attachment description: Fix all accesskey conflicts this time [Checkin: Comment 5] → Fix all accesskey conflicts this time [Checkin: Comment 5, aurora/beta Comment 8]
Assignee

Updated

8 years ago
Target Milestone: seamonkey2.4 → seamonkey2.2
Target Milestone: seamonkey2.2 → seamonkey2.4
You need to log in before you can comment on or make changes to this bug.