Jprof doesn't build shared library

RESOLVED FIXED

Status

()

Core
General
--
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jesup, Assigned: jesup)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(firefox6 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
jprof doesn't build a shared library by default (it seemed to work back in April when I was developing the jprof updates, but doesn't anymore).  Force jprof to be a shared lib.

Also, the build instructions in the README.html are incorrect (missed that in the last update)
(Assignee)

Updated

6 years ago
Assignee: nobody → rjesup
(Assignee)

Comment 1

6 years ago
Created attachment 536427 [details] [diff] [review]
Simple fix to force a shared library and fix build instructions

Just need to figure out who should review this (trying to be nice to bz ;-)  Also we'll need to decide if it needs to get merged into FF6
(Assignee)

Updated

6 years ago
Attachment #536427 - Flags: review?(khuey)
Attachment #536427 - Flags: review?(khuey) → review+
(Assignee)

Comment 2

6 years ago
Checked in as http://hg.mozilla.org/mozilla-central/rev/16dc1fd9c28a

Leaving open for consideration for Aurora - this is a debug-tools only patch that would be nice not to have to hand-apply to look at any perf issues in Aurora.  Not by any means critical though.  Dropping to 'minor'
Severity: normal → minor
Status: NEW → ASSIGNED
> Leaving open for consideration for Aurora

That's tracked via the status-firefox6 and tracking-firefox6 flags on the bug and the approval flags on the patch.  Once a bug is on m-c, the status needs to change to FIXED.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 4

6 years ago
Comment on attachment 536427 [details] [diff] [review]
Simple fix to force a shared library and fix build instructions

Thanks - the status/tracking stuff is changed since 8 years ago.  :-)  

Nominating for Aurora/FireFox6.
Attachment #536427 - Flags: approval-mozilla-aurora?

Comment 5

6 years ago
Comment on attachment 536427 [details] [diff] [review]
Simple fix to force a shared library and fix build instructions

NPOTB is an easy approval.
Attachment #536427 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

6 years ago
Fix checked into Aurora: http://hg.mozilla.org/releases/mozilla-aurora/rev/736bfe524cc2
(Assignee)

Updated

6 years ago
Attachment #536427 - Flags: checkin+
(Assignee)

Updated

6 years ago
status-firefox6: --- → fixed
You need to log in before you can comment on or make changes to this bug.