661043 - Testing frame work should handle event listener in itself

Status: NEW

(Testing :: Mochitest, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

For example, many tests have codes like this:

window.addEventListener("needThisEvent", function(event) {
  window.removeEventListener("needThisEvent", arguments.callee, false);
  ...
}, false);

But this listener is not removed when the test is timed out.

So we currently have to do something like this:

var listener = function(event) {
 ..
}
registerCleanupFunction(function() {
  window.removeEventListener("needThisEvent", listener, false);
});
window.addEventListener("needThisEvent", listener, false);

But this code is a little bit inconvenient to write, many test codes does actually not use registerCleanupFunction for removal of event listener.

So I'd propose more convenient way and testing frame work does remove event listener even if the test is timed out.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Proposed patch

Add registerEventListener and unregisterEventListener.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Bug 454717 is related.

IIRC removeEventListener can't throw, so I don't think you need the try/catch.

A unregisterListener(listeningObject) method would allow sharing some code.