661136 - websockets setuprequest in redirect path return not used

Status: RESOLVED FIXED

(Core :: Networking: WebSockets, defect)

Description

[Patrick McManus [:mcmanus]]

Brian noted this. It probably just means a later failure than we should have.

this path is pref'd off.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: 661136-error-handler.1

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 536609 [details] [diff] [review]
661136-error-handler.1

+        callback->OnRedirectVerifyCallback(NS_ERROR_FAILURE);

why not rv?

Comment 3

[Patrick McManus [:mcmanus]]

(In reply to comment #2)
> Comment on attachment 536609 [details] [diff] [review] [review]
> 661136-error-handler.1
> 
> +        callback->OnRedirectVerifyCallback(NS_ERROR_FAILURE);
> 
> why not rv?

I have a broken mental model that the redirect verify callback takes a bool.

I'll fix that and the other ones like it.

Comment 4

[Patrick McManus [:mcmanus]]

Attachment: 661136 error handler 2

updated to propogate failed nsresult on failure.

Comment 5

[Patrick McManus [:mcmanus]]

http://hg.mozilla.org/mozilla-central/rev/f36255c3ad88

this path is pref'd off on aurora so I'm not going to request it land there.