The default bug view has changed. See this FAQ.

websockets setuprequest in redirect path return not used

RESOLVED FIXED

Status

()

Core
Networking: WebSockets
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mcmanus, Assigned: mcmanus)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Brian noted this. It probably just means a later failure than we should have.

this path is pref'd off.
(Assignee)

Comment 1

6 years ago
Created attachment 536609 [details] [diff] [review]
661136-error-handler.1
Assignee: nobody → mcmanus
Attachment #536609 - Flags: review?(cbiesinger)
Comment on attachment 536609 [details] [diff] [review]
661136-error-handler.1

+        callback->OnRedirectVerifyCallback(NS_ERROR_FAILURE);

why not rv?
Attachment #536609 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> Comment on attachment 536609 [details] [diff] [review] [review]
> 661136-error-handler.1
> 
> +        callback->OnRedirectVerifyCallback(NS_ERROR_FAILURE);
> 
> why not rv?

I have a broken mental model that the redirect verify callback takes a bool.

I'll fix that and the other ones like it.
(Assignee)

Comment 4

6 years ago
Created attachment 536972 [details] [diff] [review]
661136 error handler 2

updated to propogate failed nsresult on failure.
Attachment #536609 - Attachment is obsolete: true
Attachment #536972 - Flags: review?(cbiesinger)
Attachment #536972 - Flags: review?(cbiesinger) → review+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/f36255c3ad88

this path is pref'd off on aurora so I'm not going to request it land there.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.