Last Comment Bug 661136 - websockets setuprequest in redirect path return not used
: websockets setuprequest in redirect path return not used
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Networking: WebSockets (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: Patrick McManus [:mcmanus]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-01 06:35 PDT by Patrick McManus [:mcmanus]
Modified: 2011-06-03 07:49 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
661136-error-handler.1 (1.26 KB, patch)
2011-06-01 07:21 PDT, Patrick McManus [:mcmanus]
cbiesinger: review+
Details | Diff | Review
661136 error handler 2 (2.38 KB, patch)
2011-06-02 14:12 PDT, Patrick McManus [:mcmanus]
cbiesinger: review+
Details | Diff | Review

Description Patrick McManus [:mcmanus] 2011-06-01 06:35:35 PDT
Brian noted this. It probably just means a later failure than we should have.

this path is pref'd off.
Comment 1 Patrick McManus [:mcmanus] 2011-06-01 07:21:40 PDT
Created attachment 536609 [details] [diff] [review]
661136-error-handler.1
Comment 2 Christian :Biesinger (don't email me, ping me on IRC) 2011-06-02 13:38:58 PDT
Comment on attachment 536609 [details] [diff] [review]
661136-error-handler.1

+        callback->OnRedirectVerifyCallback(NS_ERROR_FAILURE);

why not rv?
Comment 3 Patrick McManus [:mcmanus] 2011-06-02 14:11:23 PDT
(In reply to comment #2)
> Comment on attachment 536609 [details] [diff] [review] [review]
> 661136-error-handler.1
> 
> +        callback->OnRedirectVerifyCallback(NS_ERROR_FAILURE);
> 
> why not rv?

I have a broken mental model that the redirect verify callback takes a bool.

I'll fix that and the other ones like it.
Comment 4 Patrick McManus [:mcmanus] 2011-06-02 14:12:53 PDT
Created attachment 536972 [details] [diff] [review]
661136 error handler 2

updated to propogate failed nsresult on failure.
Comment 5 Patrick McManus [:mcmanus] 2011-06-03 07:49:44 PDT
http://hg.mozilla.org/mozilla-central/rev/f36255c3ad88

this path is pref'd off on aurora so I'm not going to request it land there.

Note You need to log in before you can comment on or make changes to this bug.