Closed Bug 661289 Opened 12 years ago Closed 12 years ago

Scratchpad Save File prompts to overwrite existing files twice.

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rcampbell, Assigned: JasnaPaka)

Details

(Whiteboard: [scratchpad][good-first-bugs][fixed-in-fx-team])

Attachments

(1 file)

[checked-in] Patch v1
811 bytes, patch
rcampbell
: review+
Details | Diff | Splinter Review 
STR:

1. Open a Scratchpad.
2. Enter some text.
3. Select Save As from the File menu.
4. Save it as Scratchpad.js to the default location.
5. Select Save As from the File menu.
6. Save it as Scratchpad.js to the default location.

Expected results:

File dialog should prompt asking if the user wishes to replace the file.

Actual:

File dialog prompts, then another prompt appears in the scratchpad window asking if you would like to replace the file.

That is 1 too many prompts!
Whiteboard: [scratchpad][good-first-bugs]
Target Milestone: --- → Firefox 7
Version: unspecified → 7 Branch
bugzilla, why do you so often get my flags wrong?
Target Milestone: Firefox 7 → ---
Version: 7 Branch → Trunk
Assignee: nobody → pcvrcek
Status: NEW → ASSIGNED
Maybe something like this?
Attachment #551884 - Flags: review?(rcampbell)
Comment on attachment 551884 [details] [diff] [review]
[checked-in] Patch v1

looks like it'll do the trick! Thanks for the patch! :)
Attachment #551884 - Flags: review?(rcampbell) → review+
Whiteboard: [scratchpad][good-first-bugs] → [scratchpad][good-first-bugs][land-in-fx-team]
Whiteboard: [scratchpad][good-first-bugs][land-in-fx-team] → [scratchpad][good-first-bugs][fixed-in-fx-team]
Comment on attachment 551884 [details] [diff] [review]
[checked-in] Patch v1

http://hg.mozilla.org/integration/fx-team/rev/4d97114b4e60
Attachment #551884 - Attachment description: Patch v1 → [in-fx-team] Patch v1
Comment on attachment 551884 [details] [diff] [review]
[checked-in] Patch v1

http://hg.mozilla.org/mozilla-central/rev/4d97114b4e60
Attachment #551884 - Attachment description: [in-fx-team] Patch v1 → [checked-in] Patch v1
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.