Scratchpad Save File prompts to overwrite existing files twice.

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rc, Assigned: JasnaPaka)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [scratchpad][good-first-bugs][fixed-in-fx-team])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
STR:

1. Open a Scratchpad.
2. Enter some text.
3. Select Save As from the File menu.
4. Save it as Scratchpad.js to the default location.
5. Select Save As from the File menu.
6. Save it as Scratchpad.js to the default location.

Expected results:

File dialog should prompt asking if the user wishes to replace the file.

Actual:

File dialog prompts, then another prompt appears in the scratchpad window asking if you would like to replace the file.

That is 1 too many prompts!
(Reporter)

Updated

6 years ago
Whiteboard: [scratchpad][good-first-bugs]
Target Milestone: --- → Firefox 7
Version: unspecified → 7 Branch
(Reporter)

Comment 1

6 years ago
bugzilla, why do you so often get my flags wrong?
Target Milestone: Firefox 7 → ---
Version: 7 Branch → Trunk
(Assignee)

Updated

6 years ago
Assignee: nobody → pcvrcek
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 551884 [details] [diff] [review]
[checked-in] Patch v1

Maybe something like this?
Attachment #551884 - Flags: review?(rcampbell)
(Reporter)

Comment 3

6 years ago
Comment on attachment 551884 [details] [diff] [review]
[checked-in] Patch v1

looks like it'll do the trick! Thanks for the patch! :)
Attachment #551884 - Flags: review?(rcampbell) → review+
(Reporter)

Updated

6 years ago
Whiteboard: [scratchpad][good-first-bugs] → [scratchpad][good-first-bugs][land-in-fx-team]
(Reporter)

Updated

6 years ago
Whiteboard: [scratchpad][good-first-bugs][land-in-fx-team] → [scratchpad][good-first-bugs][fixed-in-fx-team]
(Reporter)

Comment 4

6 years ago
Comment on attachment 551884 [details] [diff] [review]
[checked-in] Patch v1

http://hg.mozilla.org/integration/fx-team/rev/4d97114b4e60
Attachment #551884 - Attachment description: Patch v1 → [in-fx-team] Patch v1
(Reporter)

Comment 5

6 years ago
Comment on attachment 551884 [details] [diff] [review]
[checked-in] Patch v1

http://hg.mozilla.org/mozilla-central/rev/4d97114b4e60
Attachment #551884 - Attachment description: [in-fx-team] Patch v1 → [checked-in] Patch v1
(Reporter)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.