Last Comment Bug 661292 - Make nsChangeObserver::ContentInserted not use the index parameter
: Make nsChangeObserver::ContentInserted not use the index parameter
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Cocoa (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Mounir Lamouri (:mounir)
:
:
Mentors:
Depends on:
Blocks: 651121 661296
  Show dependency treegraph
 
Reported: 2011-06-01 10:42 PDT by Mounir Lamouri (:mounir)
Modified: 2011-06-03 03:15 PDT (History)
0 users
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (1.84 KB, patch)
2011-06-01 10:42 PDT, Mounir Lamouri (:mounir)
no flags Details | Diff | Splinter Review
Patch v1 (6.69 KB, patch)
2011-06-01 10:57 PDT, Mounir Lamouri (:mounir)
jaas: review+
Details | Diff | Splinter Review

Description Mounir Lamouri (:mounir) 2011-06-01 10:42:19 PDT
Created attachment 536657 [details] [diff] [review]
Patch v1

Unfortunately, I *have* to use IndexOf() given that, if I understand it correctly, we have an array of menu that reflects the DOM and we will have to look for the index at some point. It will be slower but nothing significant I believe.
Comment 1 Mounir Lamouri (:mounir) 2011-06-01 10:57:37 PDT
Created attachment 536666 [details] [diff] [review]
Patch v1

I did update the wrong patch... :(
Comment 2 Mounir Lamouri (:mounir) 2011-06-03 03:15:39 PDT
Pushed:
http://hg.mozilla.org/mozilla-central/rev/8877ab5935f0

Note You need to log in before you can comment on or make changes to this bug.