Created attachment 536870 [details] [diff] [review] fix v1.0 mozilla-central/netwerk/protocol/websocket/nsWebSocketHandler.cpp:966:36: error: cast from 'PRUint8*' to 'long unsigned int' loses precision [-fpermissive] That's because long is 32-bit on win64. In this case we don't care about losing precision, but it's still an error for GCC. The fix is as simple as using uintptr_t.
Could you cast to some PRU*** type?
Comment on attachment 536870 [details] [diff] [review] fix v1.0 Or, uintptr_t could be ok, but this is Patrick's code
Created attachment 537132 [details] [diff] [review] fix using PRUptrdiff The attached patch uses PRUptrdiff instead of uintptr_t. Please choose preferred version.
Comment on attachment 536870 [details] [diff] [review] fix v1.0 Review of attachment 536870 [details] [diff] [review]: ----------------------------------------------------------------- Jacek, what do you think about using PRUptrdiff ? There are a number of places in the code base (netwerk is not one of them) that go to some length to make sure uintptr_t is defined for old platforms.
(In reply to comment #3) > Created attachment 537132 [details] [diff] [review] [review] > fix using PRUptrdiff > > The attached patch uses PRUptrdiff instead of uintptr_t. Please choose > preferred version. heh - race condition. good to go.
Thanks for the review, pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/780fb17abc1e
or
