661517 - nsWebSocketHandler.cpp fails to compile on mingw-w64

Status: RESOLVED FIXED

Description

[Jacek Caban]

Created attachment 536870 [details] [diff] [review]
fix v1.0

mozilla-central/netwerk/protocol/websocket/nsWebSocketHandler.cpp:966:36: error: cast from 'PRUint8*' to 'long unsigned int' loses precision [-fpermissive]

That's because long is 32-bit on win64. In this case we don't care about losing precision, but it's still an error for GCC. The fix is as simple as using uintptr_t.

Comment 1

[Olli Pettay [:smaug]]

Could you cast to some PRU*** type?

Comment 2

[Olli Pettay [:smaug]]

Comment on attachment 536870 [details] [diff] [review]
fix v1.0

Or, uintptr_t could be ok, but this is Patrick's code

Comment 3

[Jacek Caban]

Created attachment 537132 [details] [diff] [review]
fix using PRUptrdiff

The attached patch uses PRUptrdiff instead of uintptr_t. Please choose preferred version.

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 536870 [details] [diff] [review]
fix v1.0

Review of attachment 536870 [details] [diff] [review]:
-----------------------------------------------------------------

Jacek, what do you think about using PRUptrdiff ?

There are a number of places in the code base (netwerk is not one of them) that go to some length to make sure uintptr_t is defined for old platforms.

Comment 5

[Patrick McManus [:mcmanus]]

(In reply to comment #3)
> Created attachment 537132 [details] [diff] [review] [review]
> fix using PRUptrdiff
> 
> The attached patch uses PRUptrdiff instead of uintptr_t. Please choose
> preferred version.

heh - race condition.

good to go.

Comment 6

[Jacek Caban]

Thanks for the review, pushed to m-c:

http://hg.mozilla.org/mozilla-central/rev/780fb17abc1e