661533 - see also should support Review Board urls

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Matt Selsky [:selsky]]

Attachment: Add support for Review Board review request URLs v1

See Also should support Review Board review request urls of the form http://reviews.reviewboard.org/r/111/

Comment 1

[Tiago Mello [:timello]]

Comment on attachment 536888 [details] [diff] [review]
Add support for Review Board review request URLs v1

Review of attachment 536888 [details] [diff] [review]:
-----------------------------------------------------------------

::: Bugzilla/BugUrl/ReviewBoard.pm
@@ +23,5 @@
> +use base qw(Bugzilla::BugUrl);
> +
> +use Bugzilla::Error;
> +use Bugzilla::Util;
> +

You are not using any method from Bugzilla::Error and neither from Bugzilla::Util. So get ride of these lines.

@@ +39,5 @@
> +
> +    my $uri = $class->SUPER::_check_value(@_);
> +
> +    # Review Board URLs have only one form:
> +    #   http://reviews.reviewboard.org/r/111/

Your example does not work. The code does not accept the last '/'.

Comment 2

[Matt Selsky [:selsky]]

Attachment: Add support for Review Board review request URLs v2

Patch updated as requested.

Comment 3

[Tiago Mello [:timello]]

Comment on attachment 552843 [details] [diff] [review]
Add support for Review Board review request URLs v2

The patch applies cleanly and it passes in all tests! Thanks Matt! Sorry again for the delay on reviewing it.

Comment 4

[Matt Selsky [:selsky]]

Do I need to provide a release notes patch, or is that done when the release is cut?

Comment 5

[Tiago Mello [:timello]]

(In reply to Matt Selsky [:selsky] from comment #4)
> Do I need to provide a release notes patch, or is that done when the release
> is cut?

This will be done when we release 5.0. This keyword is to avoid losing track of new features.

Comment 6

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/BugUrl.pm
added Bugzilla/BugUrl/ReviewBoard.pm
modified template/en/default/global/user-error.html.tmpl
Committed revision 8061.

Comment 7

[Matt Selsky [:selsky]]

Do you want the license updated to MPL 2.0?

Comment 8

[Frédéric Buclin]

Added to relnotes for 4.4.