66172 - nsEventStatus "out" param isn't always set on HandleDOMEvent

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P5)

Description

[Mike Pinkerton (not reading bugmail)]

As demonstrated in the Great Image Submit Fiasco Bug, the |aStatus| parameter
that comes out of |nsPresShell::HandleDOMEventWithTarget()| doesn't always get
set to a value as it used to. This probably means that there are circumstances
where |HandleDOMEvent()| (which is called from that method) does not set the
status and leaves it uninitialized.

Placeholder opened by request from jst so he can look into it.

Comment 1

[timeless]

Attachment: initialize nsEventStatus status

Comment 2

[timeless]

would someone please review this code? it fell off my wishlist a while ago, but 
the patch is here, ... waiting.

Comment 3

[Johnny Stenback (:jst)]

timeless, your patch looks good to me and I think it's worth checking in, but
unfortunately it doesn't fix this bug, this bug was filed to make sure all
implmentations of HandleDOMEvent() really set the nsEventState out parameter
when they were called, not that all nsEventState parameters were initialized
before calling HandleDOMEvent(). r=jst for the patch, but the patch is not
enough to fix this bug.

Comment 4

[Johnny Stenback (:jst)]

sr=jst for the patch

Comment 5

[saari (gone)]

r=saari for the patch

Comment 6

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 7

[Prashant Desale]

Severity = LOW [No Crash, No severe functional failure, No Cosmetic failure]
Visibility = LOW [Dont see any real world website usage] 

Priority = Visibility * Severity

Priority = p5

adding word "qawanted" because I'm setting this priority on available data & if 
someone feels otherwise then please investigate this more & feel free to change 
this priority.

Comment 8

[Johnny Stenback (:jst)]

Mass-reassigning bugs to [e-mail]

Comment 9

[Simon Paquet [:sipaq]]

This bug is targeted at a Mac classic platform/OS, which is no longer supported
by mozilla.org. Please re-target it to another platform/OS if this bug applies
there as well or resolve this bug.

I will resolve this bug as WONTFIX in four weeks if no action has been taken.
To filter this and similar messages out, please filter for "mac_cla_reorg".

Comment 10

[Frankie]

Mac Classic RIP

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

not mac specific

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

(In reply to comment #3)
> this bug was filed to make sure all
> implmentations of HandleDOMEvent() really set the nsEventState out parameter
> when they were called, not that all nsEventState parameters were initialized
> before calling HandleDOMEvent()

Since there aren't any HandleDOMEvent methods anymore, I'd call this fixed.

Comment 13

[timeless]

fwiw smaug used bug 234455 to kill that method